Respect amount
when listing releases
#63
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
ListReleases
to respect theamount
value.Implementation
ListReleases
would keep looping until theEndCursor
even when theamount
was set to 1 and the release had already been found. I have now updated the conditional check that determines whether the loop should continue or break.amount
might be misinterpreted as it is used as thefirst
parameter in the GraphQL release query. This meansamount
is the number of releases that GitHub should return per query (more like per page). Instead, theamount
is the maximum number of releases that should be returned after filtering. To correct this, I have set a fixed value of10
for thefirst
variable. This also now makes finding a single release faster since GitHub will now return 10 release nodes per query.