Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken zarr intersphinx, limit zarr to < 3 #1229

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Fix broken zarr intersphinx, limit zarr to < 3 #1229

merged 4 commits into from
Jan 10, 2025

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 10, 2025

Motivation

Zarr intersphinx links are broken because of the recent update to Zarr v3. Fix the links and limit zarr version to < 3 until hdmf-zarr and hdmf support zarr v3.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@rly rly requested a review from oruebel January 10, 2025 17:24
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (85c9af8) to head (9b658bf).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1229   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files          42       42           
  Lines        9524     9524           
  Branches     2725     2725           
=======================================
  Hits         8654     8654           
  Misses        576      576           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly merged commit a7a5507 into dev Jan 10, 2025
29 checks passed
@rly rly deleted the fix-zarr-links branch January 10, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants