-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unwrap TermSetWrapper in ObjectMapper and not the IO #1070
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1070 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 45 45
Lines 9616 9616
Branches 2738 2738
=======================================
Hits 8515 8515
Misses 778 778
Partials 323 323 ☔ View full report in Codecov by Sentry. |
Review Notes: I am going to investigate how this would work on references. We don't have tests for those situations (pointing to a container that has a wrapped data/attribute field. This PR is a fix to continue the status quo, but now outside the backend specific IO. I will make a new PR for the reference case. That PR will not be included in the release on March 19. |
Review notes:
|
Could you move it to |
I can! I just thought you wanted it moved from your prior comment. |
Sorry for the confusion. I meant that the existing tests should not be modified unnecessarily, but you can add classes or methods to |
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
Goal: Remove the unwrapping of TermSetWrapper from HDF5IO to base HDMF. Why? The current setup only allows TermSetWrapper to be unwrapped for HDF5 and not Zarr. The desire is to not have two IO classes dealing with the unwrapping, but one shared tool.
Unwrap in the mapper.
How to test the behavior?
Checklist
CHANGELOG.md
with your changes?