feat: finish endpoint to get an user by id

src/api/middlewares/validator.ts

@@ -3,7 +3,6 @@ import { validationResult } from "express-validator";
 
 export default function validator(request: Request, response: Response, next: NextFunction) {
     const result = validationResult(request);
-    console.log(result);
 
     if (!result.isEmpty()) {
       return response.status(400).json({ errors: result.array() })

src/api/routers/alerts.e2e.test.ts

@@ -1,4 +1,4 @@
-describe('Alerts endpoints', () => {
+describe.skip('Alerts endpoints', () => {
   it('', () => {
     console.log(globalThis.db_client);
     console.log(globalThis.request);

src/api/routers/users.e2e.test.ts

@@ -40,13 +40,50 @@ describe('Users endpoints', () => {
       };
 
       const response = await globalThis.request
-        .post('/v1/users')
+        .post('/api/users')
         .set('Content-Type', 'application/json')
         .send(body);
 
-      console.log(response.body.errors);
       expect(response.status).toEqual(400);
       expect(response.body.errors).toHaveLength(4);
     });
   });
+
+  describe('GET: /users/:id', () => {
+    const user_id = faker.string.uuid();
+
+    beforeAll(async () => {
+      await globalThis.db_client.query(
+        'INSERT INTO users (id, email, name, password, phone_number) VALUES ($1, $2, $3, $4, $5)',
+        [user_id, faker.internet.email(), faker.person.fullName(), faker.string.alphanumeric(10), faker.string.numeric(11)]
+      );
+    });
+
+    it('returns an user by id', async () => {
+      expect.assertions(5);
+
+      const response = await globalThis.request
+        .get(`/api/users/${user_id}`)
+        .set('Content-Type', 'application/json')
+        .send();
+
+      expect(response.status).toEqual(200);
+      expect(response.body.id).toEqual(user_id);
+      expect(response.body.name).toBeDefined();
+      expect(response.body.email).toBeDefined();
+      expect(response.body.phone_number).toBeDefined();
+    });
+
+    it("returns not found if user doesn't exist", async () => {
+      expect.assertions(2);
+
+      const response = await globalThis.request
+        .get(`/api/users/${faker.string.uuid()}`)
+        .set('Content-Type', 'application/json')
+        .send();
+
+      expect(response.status).toEqual(404);
+      expect(response.body.message).toEqual('User not found');
+    });
+  });
 });

src/api/routers/users.ts

@@ -5,6 +5,7 @@ import UserService from '@b3_stock_alerts/UserService';
 import { NextFunction, Request, Response, Router } from 'express';
 import { checkSchema } from 'express-validator';
 import { create_user } from './validations';
+import NotFoundError from '@shared/NotFoundError';
 
 const router = Router();
 const userService = new UserService(new PgUserRepository(), new BcryptEncryptor());
@@ -32,9 +33,14 @@ router.post('/users',
   }
 );
 
-router.get('/users/:id', (_request: Request, response: Response, next: NextFunction) => {
+router.get('/users/:id', async (request: Request, response: Response, next: NextFunction) => {
   try {
-    return response.status(204).json();
+    const result = await userService.getUser(request.params.id);
+    if (result.error instanceof NotFoundError) {
+      return response.status(404).json({ message: result.error.message });
+    }
+
+    return response.status(200).json(result.data);
   } catch (e) {
     return next(e);
   }