Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Russian language #470

Merged
merged 14 commits into from
Feb 17, 2025
Merged

Support for Russian language #470

merged 14 commits into from
Feb 17, 2025

Conversation

Sat1l
Copy link
Contributor

@Sat1l Sat1l commented Dec 28, 2024

Added support for Russian language + a script that would move generated font files to the lvgl folder just because.

@Sat1l
Copy link
Contributor Author

Sat1l commented Dec 28, 2024

as of now it just bootloops the goggle if Russian file is specified, but english/chinese are OK. Also if I replace characters in en/ch with cyrillic letters it just works, but with rus - nope

@Sat1l
Copy link
Contributor Author

Sat1l commented Jan 1, 2025

got the goggles to boot up with a new lang but some strings do not get replaced / get torn apart / do not respect a newline symbol and just show it

@ligenxxxx
Copy link
Member

ligenxxxx commented Jan 22, 2025

Please see this, I removed the \n in the .ini file. #474
Also the firmware still cannot be translated correctly. #475

@Sat1l
Copy link
Contributor Author

Sat1l commented Jan 27, 2025

Funnily enough - the same issue as with my previous attempt at i18n happened - a segfault happens when exiting the clock page. This is also present in Chinese translation of the upstream.

The fixes were very nice, but i still face some issues when translating:
Sometimes there are two dots at the end of the notes, even when only one dot is placed in .ini file, this also happens in Chinese translation - e.g. in the "Recording" page both rows of the note have double dots at the end.

Sometimes the second row of the note is being chopped off randomly - in “Image” at “Make sure a HDZero VTX or analog VTX is powered on for live video” my translation gets cut off at “… для просмот”.
In the “recording” tab its at “TS format is highly recommended” and the translations after “Рекоме” is being cut, very early in the string.
Input menu gets a cut at “’Toggle source' will switch between HDZero and Expansion module”, after “… перекл”

@ligenxxxx
Copy link
Member

#478
I solved the problem of Clock -> Back causing app crash.

@ligenxxxx
Copy link
Member

@Sat1l You will need to do some debugging to determine where the problem occurs.

@Sat1l
Copy link
Contributor Author

Sat1l commented Feb 10, 2025

I was able to get everything working. Also fixed a couple key-translation mismatches between UI and translations.

There was no Chinese translation for "Element" (can be seen in ui_osd_element_pos), so I added the needed row with "tbd" to be fitted with appropriate translation

@Sat1l
Copy link
Contributor Author

Sat1l commented Feb 10, 2025

Also in page_wifi.c "scroll to cancel" is not internationalized - I could give it a crack but looks like it would take me much more time then it will you.

@ligenxxxx
Copy link
Member

ligenxxxx commented Feb 11, 2025

#486
I have fixed known translation issues.

@Sat1l
Copy link
Contributor Author

Sat1l commented Feb 11, 2025

The translation is now complete.

@Sat1l Sat1l marked this pull request as ready for review February 11, 2025 09:47
@ligenxxxx
Copy link
Member

ligenxxxx commented Feb 14, 2025

image
Please restore this file and remove the "..." from ru_ru.ini
We should try to avoid introducing punctuation into translations where it is unnecessary.

@ligenxxxx ligenxxxx merged commit d03e23a into hd-zero:main Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants