Add flux for creating gnd-geograpicnames map RPB-151 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited test data without changing the encoding with: `sed -i 's/1nqRegensburg/1nqhttps:\/\/d-nb.info\/gnd\/4048989-9/'`
fsteeg
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Thanks! That's a nice little lobid-request-to-lookup-map flux!
Since the build was failing due to the dependency updates, and those would require additional testing since all productive transformations could be affected, I've reverted the versions, removed the gzip option, and re-created gndGeograpicName.tsv (we're not running the transformation automatically for now, so size is no issue here).
I've also added the lookups to the RPPD transformation and deployed the result to test, looks good (example from https://jira.hbz-nrw.de/browse/RPB-151): http://test.rppd.lobid.org/10001058X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a workflow for creating a map
gndId->preferredNameof allgeographicNameswithoutBuildingsOrMemorialsorWayBorderOrLine.Higher version of MF was needed since the old version does not support gzip in
open-http.