Skip to content

Commit

Permalink
Update CONTRIBUTING.md
Browse files Browse the repository at this point in the history
Co-authored-by: TobiasNx <61879957+TobiasNx@users.noreply.github.com>
  • Loading branch information
dr0i and TobiasNx authored May 23, 2024
1 parent f52dd33 commit f13c7a4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Follow the instructions from [metafacture-playground's CONTRIBUTING.md, section

**Note**:

we differ from the above documentation when doing **Pull Requests**(PR).
We differ from the above documentation when doing **Pull Requests**(PR).
As a functional review of a PR normally needs a full indexing, which takes around 18h, the PR should not be linked to the issue by a "closing keyword" but with a "See", eg "**See #2002.**". So if the PR is merged and thus closed, it doesn't trigger the closing of the issue automatically. The issue should be revisited after weekend's deployment and checked if the PR indeed has solved the issue. It is then closed manually.

**If** an issue is **assigned** it shall always be clear for the assigned what is expected of her. E.g. one could assign and comment with: "Check after weekend's deployment".
Expand Down

0 comments on commit f13c7a4

Please sign in to comment.