Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stops displaying no containers page while waiting for pods #210 #212

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

phantomjinx
Copy link
Member

@phantomjinx phantomjinx commented Nov 24, 2023

  • management-service.ts

    • The management service is responsible for emitting an update on all the pods being managed or not. However, no update is emitted if there are no pods. As a result, the Discover component has to assume there are no pods while waiting for them.
    • To allow for the Discover component to wait for the update (showing 'loading'), fire an update when there are no pods
    • Also for each pod add a flag to show that it has now been 'managed'
  • context.ts

    • Differentiate between initialising / mounting of the context and the first call to organising the pods and the later mgmt service listener
    • Once mounted, only when the listener receives its first update will the context signal it is loaded (that signal will be either when there are pods or not hence the mandated firing from the mgmt service)
  • Discover.tsx

    • Improves the loading component to show a header to the loading card
  • DiscoverPodItem.tsx

    • In the event that a new pod is spun up, it can take several seconds for an update to be received concerning the number of routes. As a result, have the routes count label display a spinner and querying ... label before being updated to the correct total

@phantomjinx
Copy link
Member Author

loading-pr.mp4

…o#210

* management-service.ts
 * The management service is responsible for emitting an update on all
   the pods being managed or not. However, no update is emitted if there
   are no pods. As a result, the Discover component has to assume there
   are no pods while waiting for them.
 * To allow for the Discover component to wait for the update (showing
   'loading'), fire an update when there are no pods
 * Also for each pod add a flag to show that it has now been 'managed'

* context.ts
 * Differentiate between initialising / mounting of the context and the
   first call to organising the pods and the later mgmt service listener
 * Once mounted, only when the listener receives its first update will the
   context signal it is loaded (that signal will be either when there are
   pods or not hence the mandated firing from the mgmt service)

* Discover.tsx
 * Improves the loading component to show a header to the loading card

* DiscoverPodItem.tsx
 * In the event that a new pod is spun up, it can take several seconds for
   an update to be received concerning the number of routes. As a result,
   have the routes count label display a spinner and `querying ...` label
   before being updated to the correct total
@tadayosi tadayosi merged commit f9752d7 into hawtio:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants