Add support for results in csv format #725
Open
+98
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for outputting the result fo each request as CSV. This is similar as in the `hey` load generator though the CSV format is slightly different. There is also a new `--output-format` command line switch which can take values `text` (default), `json` or `csv`. Previous `-j` / `--json` flag has been removed to consolidate output selection to use the one `--output-format` flag. This seemd like a better way to handle multiple output formats instead of adding separate (exclusive) flags for each different output format.
hatoo
requested changes
Apr 5, 2025
| fn print_csv<W: Write>(w: &mut W, start: Instant, res: &ResultData) -> std::io::Result<()> { | ||
| // csv header | ||
| writeln!(w, "DNS,DNS+dialup,request-duration,bytes,status,offset")?; | ||
| for request in res.success() { |
There was a problem hiding this comment.
It should be sorted by request.start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for outputting the result of each request as CSV line. This is similar as in the
-ooption inheyload generator though the CSV format here is different.There is also a new
--output-formatcommand line switch which can take valuestext(default),jsonorcsv. Previous-j/--jsonflag has been removed to consolidate output selection to use the one--output-formatflag. This seemed like a better way to handle multiple output formats instead of adding separate (exclusive) flags for each different output format, but open to suggestions on this if there's a better way to organize the flags, also open to suggestions on the CSV format.