validate the latest version when new connector version is released #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
codingkarthik
had a problem deploying
to
staging
GitHub Actions
Failure
scriptnull
reviewed
Feb 10, 2025
scriptnull
reviewed
Feb 10, 2025
scriptnull
reviewed
Feb 13, 2025
scriptnull
reviewed
Feb 13, 2025
scriptnull
reviewed
Feb 13, 2025
There was a problem hiding this comment.
I performed a thorough review and came up with #463 to express what I was looking for. Please take a look at that PR and incorporate the changes from there as you like.
This is a refactor of things from #460 I am opening this to convey some of the code review points that I had in mind (which was a bit hard to convey in the original PR). I suggest doing the below before making use of the code from this PR: - Add tests wherever possible - Try out the new validate logic (I haven't run it in local yet) - Feel free to ask me questions on why I have written something in a certain way (compared to the original PR) --------- Co-authored-by: Karthikeyan C <karthikeyan@hasura.io>
scriptnull
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as title