Skip to content

Commit f19a125

Browse files
authored
Merge pull request #207 from hashicorp/log-secure-config-nil
client: log warning when SecureConfig is nil
2 parents a02e5c7 + 27115fc commit f19a125

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## v1.4.5
2+
3+
ENHANCEMENTS:
4+
5+
* client: log warning when SecureConfig is nil [[GH-207](https://github.com/hashicorp/go-plugin/pull/207)]
6+
7+
18
## v1.4.4
29

310
ENHANCEMENTS:

client.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,9 @@ func (c *Client) Start() (addr net.Addr, err error) {
547547
return nil, err
548548
}
549549

550-
if c.config.SecureConfig != nil {
550+
if c.config.SecureConfig == nil {
551+
c.logger.Warn("plugin configured with a nil SecureConfig")
552+
} else {
551553
if ok, err := c.config.SecureConfig.Check(cmd.Path); err != nil {
552554
return nil, fmt.Errorf("error verifying checksum: %s", err)
553555
} else if !ok {

0 commit comments

Comments
 (0)