Skip to content

add note to disable eviction before upgrade to v1.4.x #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

add note to disable eviction before upgrade to v1.4.x #739

merged 1 commit into from
Apr 7, 2025

Conversation

WebberHuang1118
Copy link
Member

@WebberHuang1118 WebberHuang1118 commented Apr 1, 2025 •
edited
Loading

Related to issue harvester/harvester#7717

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

Name Link
🔨 Latest commit 60c3108
😎 Deploy Preview https://67eca5a8e15de202b7e61cd6--harvester-preview.netlify.app

jillian-maroket
jillian-maroket reviewed Apr 1, 2025
View reviewed changes
ihcsim
ihcsim previously approved these changes Apr 1, 2025
View reviewed changes
@WebberHuang1118 WebberHuang1118 changed the title add note to disable evicetion before upgrade to v1.4.x add note to disable eviction before upgrade to v1.4.x Apr 2, 2025
@WebberHuang1118 @jillian-maroket
add note to disable evicetion before upgrade to v1.4.x
60c3108 
Signed-off-by: Webber Huang <webber.huang@suse.com>

Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com>
@WebberHuang1118
Copy link
Member Author

We usually place information about known issues in the release-specific files. I suggest moving the content to the following:

Hi @jillian-maroket, the Longhorn issue #10464 affects Harvester 1.4.x versions and differs slightly from other known upgrade issues. Specifically, users must ensure that EvictionRequested is set to false before performing the upgrade. Failing to do so may cause the Longhorn manager to crash and lead to unexpected behavior, potentially requiring manual intervention.

In my opinion, this isn't just a known issue for troubleshooting — it's a critical pre-upgrade check. That’s why I’d prefer to keep it highlighted as it currently is. What do you think? cc @ihcsim @bk201 @innobead

bk201
bk201 approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jillian-maroket jillian-maroket merged commit 607d076 into harvester:main Apr 7, 2025
4 checks passed
@derekbit
Copy link

derekbit commented Apr 7, 2025

LGTM! Thank you.
cc @ChanYiLin @COLDTURNIP @shuo-wu @PhanLe1010 @c3y1huang

@innobead
Copy link

innobead commented Apr 7, 2025

LGTM

@jillian-maroket jillian-maroket mentioned this pull request Apr 7, 2025
Merged
@Vicente-Cheng
Copy link
Contributor

sorry for the late... :(

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihcsim ihcsim ihcsim approved these changes

@bk201 bk201 bk201 approved these changes

@jillian-maroket jillian-maroket jillian-maroket approved these changes

@innobead innobead Awaiting requested review from innobead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@WebberHuang1118 @derekbit @innobead @Vicente-Cheng @ihcsim @bk201 @jillian-maroket