-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harbor Frontend Take Home Assignment #3
Open
mohitakahalo
wants to merge
21
commits into
harbor-xyz:master
Choose a base branch
from
mohitakahalo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge commit for deployment
fixing build issues
fixing build issues
fixing build css issue
@mohitakahalo : Couple of questions on the submitted work
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take home frontend assignment solution
App demo: https://frontend-take-home-mohit.vercel.app/dashboard
The app is deployed using Vercel. Feel free to play around with it. In order to run the app locally on your machine, just clone the git repo and run
yarn dev
in the git repo root, your app will start running onhttp://localhost:3000
Tech Stack Choice:
This application is built on NextJS + Typescript stack. There are multiple reasons for choosing this stack:
Component Architecture:
This app is structured using the atomic component architecture as shown below:
The philosophy of the atomic architecture is that your app (pages in case of NextJS) is divided into sub components called organisms (big stateful components with data), which are built on top of multiple molecules (smaller building blocks with some logic integrated) which can further comprise of multiple atoms (the smallest level dumb components).
This architecture allows us to build highly composable and loosely coupled UI components. For example :
<ButtonWithIcon/>
is a loosely couple molecule component which is made up of<Button/>
atom and is reused almost in all the cases with support for left icon, button text, and right icon for the same component.Have used SCSS modules for writing CSS, which enables us to separate out the CSS conflicts by applying private scope on the component classes.
Testing:
Jest
withReact Testing Library
for unit test casesCypress
for e2e test casesFor now I have added couple of basic sample test cases for both in the interest of time and scope for this assignment. We can build further on top of these integrations for a full fledged testing suite.
yarn test
npm run cypress
Notes:
Feedback is much appreciated !