Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions for Node.js 16 deprecation #361

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Update actions for Node.js 16 deprecation #361

merged 3 commits into from
Mar 1, 2024

Conversation

AdamOrmondroyd
Copy link
Collaborator

@AdamOrmondroyd AdamOrmondroyd commented Feb 18, 2024

Description

github actions have deprecated Node.js 16 in favour of Node.js 20, which requires us to update the versions of the checkout and setup-python actions to their latest versions.

Fixes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

@AdamOrmondroyd AdamOrmondroyd changed the title Node.js 16 deprecation affecting actions Node.js 16 deprecation for actions Feb 18, 2024
@AdamOrmondroyd AdamOrmondroyd changed the title Node.js 16 deprecation for actions Update actions for Node.js 16 deprecation Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b93dec5) 100.00% compared to head (3947c38) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #361   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         2978      2978           
=========================================
  Hits          2978      2978           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdamOrmondroyd AdamOrmondroyd marked this pull request as ready for review February 18, 2024 20:32
Copy link
Collaborator

@williamjameshandley williamjameshandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very reasonable. Many thanks @AdamOrmondroyd

@AdamOrmondroyd AdamOrmondroyd merged commit 8132626 into master Mar 1, 2024
20 of 22 checks passed
@AdamOrmondroyd AdamOrmondroyd deleted the actions branch March 1, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants