Store secret data in form of key, value #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoulliard
reviewed
May 4, 2023
Comment on lines
+104
to
+110
| if (StringUtils.isNotEmpty(credential.username) && StringUtils.isNotEmpty(credential.password)) { | ||
| username = credential.username; | ||
| password = credential.password; | ||
| for (CredentialParameter param : credential.params) { | ||
| secretData.put(param.paramName, toBase64(param.paramValue)); | ||
| } | ||
| } |
There was a problem hiding this comment.
In a next PR, we will review the code that we have here in order to adapt the logic according to the credential type: simple, vault, etc
We will also define in a new entity, thy keys that we must populate according to the claim binding type (= bindable idea of Ioannis) in order to return the proper fields for a datasource, broker, nosql, etc
There was a problem hiding this comment.
yes,ok. Can we merge this into the crossplane-helmbranch then?
cmoulliard
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this pull request is against the
crossplan-helmbranch.Related to #298