Added missing dependency definitions for packaging 'gwt-lib' in BOM

hal · Apr 13, 2024 · aebf1e4 · aebf1e4
1 parent 83f4f82
commit aebf1e4
Show file tree

Hide file tree

Showing 6 changed files with 78 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+### Fixed
+
+- Added missing dependency definitions for packaging `gwt-lib` in BOM
+
 ## [1.4.4] - 2024-04-13
 
 ### Changed

diff --git a/README.md b/README.md
@@ -34,17 +34,42 @@ Elemento simplifies working with [Elemental2](https://github.com/google/elementa
 
 # Get Started
 
-Elemento is available in [Maven Central](https://search.maven.org/search?q=g:org.jboss.elemento%20AND%20a:elemento-core). To use it add the following dependency to your POM:
+Elemento is available in [Maven Central](https://search.maven.org/search?q=g:org.jboss.elemento%20AND%20a:elemento-core). The easiest way is to import its BOM
+
+```xml
+<dependencyManagement>
+    <dependencies>
+        <dependency>
+            <groupId>org.jboss.elemento</groupId>
+            <artifactId>elemento-bom</artifactId>
+            <version>1.4.4</version>
+            <type>pom</type>
+            <scope>import</scope>
+        </dependency>
+    </dependencies>
+</dependencyManagement>
+```
+
+and add a dependency to either
+
+```xml
+<dependency>
+    <groupId>org.jboss.elemento</groupId>
+    <artifactId>elemento-core</artifactId>
+    <type>gwt-lib</type>
+</dependency>
+```
+
+or
 
 ```xml
 <dependency>
     <groupId>org.jboss.elemento</groupId>
     <artifactId>elemento-core</artifactId>
-    <version>1.4.4</version>
 </dependency>
 ```
 
-In your GWT module inherit from `org.jboss.elemento.Core`:
+depending on your stack. If you're using GWT, inherit from `org.jboss.elemento.Core`:
 
 ```xml
 <module>

diff --git a/bom/pom.xml b/bom/pom.xml
@@ -48,31 +48,67 @@
                 <groupId>${project.groupId}</groupId>
                 <artifactId>elemento-core</artifactId>
                 <version>${project.version}</version>
+                <type>jar</type>
+            </dependency>
+            <dependency>
+                <groupId>${project.groupId}</groupId>
+                <artifactId>elemento-core</artifactId>
+                <version>${project.version}</version>
+                <type>gwt-lib</type>
             </dependency>
             <dependency>
                 <groupId>${project.groupId}</groupId>
                 <artifactId>elemento-flow</artifactId>
                 <version>${project.version}</version>
+                <type>jar</type>
+            </dependency>
+            <dependency>
+                <groupId>${project.groupId}</groupId>
+                <artifactId>elemento-flow</artifactId>
+                <version>${project.version}</version>
+                <type>gwt-lib</type>
             </dependency>
             <dependency>
                 <groupId>${project.groupId}</groupId>
                 <artifactId>elemento-mathml</artifactId>
                 <version>${project.version}</version>
+                <type>jar</type>
+            </dependency>
+            <dependency>
+                <groupId>${project.groupId}</groupId>
+                <artifactId>elemento-mathml</artifactId>
+                <version>${project.version}</version>
+                <type>gwt-lib</type>
+            </dependency>
+            <dependency>
+                <groupId>${project.groupId}</groupId>
+                <artifactId>elemento-router</artifactId>
+                <version>${project.version}</version>
+                <type>jar</type>
             </dependency>
             <dependency>
                 <groupId>${project.groupId}</groupId>
                 <artifactId>elemento-router</artifactId>
                 <version>${project.version}</version>
+                <type>gwt-lib</type>
             </dependency>
             <dependency>
                 <groupId>${project.groupId}</groupId>
                 <artifactId>elemento-router-processor</artifactId>
                 <version>${project.version}</version>
+                <type>jar</type>
+            </dependency>
+            <dependency>
+                <groupId>${project.groupId}</groupId>
+                <artifactId>elemento-svg</artifactId>
+                <version>${project.version}</version>
+                <type>jar</type>
             </dependency>
             <dependency>
                 <groupId>${project.groupId}</groupId>
                 <artifactId>elemento-svg</artifactId>
                 <version>${project.version}</version>
+                <type>gwt-lib</type>
             </dependency>
         </dependencies>
     </dependencyManagement>

diff --git a/samples/flow/pom.xml b/samples/flow/pom.xml
@@ -53,10 +53,12 @@
         <dependency>
             <groupId>${project.groupId}</groupId>
             <artifactId>elemento-core</artifactId>
+            <type>gwt-lib</type>
         </dependency>
         <dependency>
             <groupId>${project.groupId}</groupId>
             <artifactId>elemento-flow</artifactId>
+            <type>gwt-lib</type>
         </dependency>
         <dependency>
             <groupId>org.patternfly</groupId>

diff --git a/samples/pom.xml b/samples/pom.xml
@@ -67,6 +67,13 @@
                 <groupId>${project.groupId}</groupId>
                 <artifactId>elemento-todo-sample-common</artifactId>
                 <version>${project.version}</version>
+                <type>jar</type>
+            </dependency>
+            <dependency>
+                <groupId>${project.groupId}</groupId>
+                <artifactId>elemento-todo-sample-common</artifactId>
+                <version>${project.version}</version>
+                <type>gwt-lib</type>
             </dependency>
             <dependency>
                 <groupId>${project.groupId}</groupId>

diff --git a/samples/todo/gwt/pom.xml b/samples/todo/gwt/pom.xml
@@ -37,6 +37,7 @@
         <dependency>
             <groupId>${project.groupId}</groupId>
             <artifactId>elemento-todo-sample-common</artifactId>
+            <type>gwt-lib</type>
         </dependency>
         <dependency>
             <groupId>${project.groupId}</groupId>