Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.sh as a dependency #102

Open
darrylAlexander opened this issue Oct 6, 2018 · 5 comments
Open

Remove setup.sh as a dependency #102

darrylAlexander opened this issue Oct 6, 2018 · 5 comments

Comments

@darrylAlexander
Copy link

darrylAlexander commented Oct 6, 2018

Hi All,

I came across Precious Plastics earlier this summer and it is amazing! Good job on the site so far, I would like to get involved as well and as I am a software engineer, I thought would start here. I have read through the other issues and thought I would raise a new one for this particular problem. Please let me know if this was wrong and whether it fits somewhere else.

Currently the docker container for the site requires running setup.sh after running the container. Docker containers are supposed to contain everything you need without having to run destructive processes after it. I think the docker solution should be able to do everything we need without having to run additional processes.

I propose creating the site from the official WordPress image and using the RUN commands in a docker file to install dependencies for plugins and the plugins themselves. the compose file could be amended as well removing anything no longer needed and tweaks to volume maps, WordPress, MySQL config, etc...

If you accept this issue, I would also be willing to have a go at doing this. I've played around with this and have managed to get the theme installed from using the WordPress image as a base.

What do you think?

@davehakkens
Copy link
Member

thanks! @nzchicken was working on this, maybe he could help out?
That said, we are currently working on a much bigger ambitious project using react and node.js. Not sure if thats your cup of tea but we could also really use some help there 🤘

@darrylAlexander
Copy link
Author

@davehakkens - I would be happy to help out with the much bigger ambitious project of using react and node.js. I have used JavaScript loads with node.js. I haven't used react but I can learn it and contribute no problem. Just point me in the right direction.

@davehakkens
Copy link
Member

thanks for getting in touch, we're just in the process of setting up the repository for the new site and can share with you in the next few days 👊

@thisismattia
Copy link

Hey @darrylAlexander

After some time setting up the infrastructure (both online and offline), we’re now writing you to let you know that the github repo for the new web platform is finally live!

If you’re still interested in contributing to the platform we suggest you check out the contributing guidelines section for the best ways to get involved.

https://github.com/OneArmyWorld/onearmy/blob/dev/CONTRIBUTING.md

Good day!
Mattia :)

@darrylAlexander
Copy link
Author

@mattia-io thanks for this. I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants