Only check server url when username is empty #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Feb 21, 2025
src/account-mgr.cpp
Outdated
| if (rpc->getRepoProperty(repo_id, "username", &username) < 0) { | ||
| return Account(); | ||
| for (size_t i = 0; i < accounts.size(); i++) { |
There was a problem hiding this comment.
这个逻辑可以合并到下面的 for 循环里面吧。还需要注释一下，9.0.7 之前同步的资料库是没有 username 这个属性的。
src/account-mgr.cpp
Outdated
| @@ -105,19 +105,22 @@ QStringList collectSyncedReposForAccount(const Account& account) | |||
| LocalRepo repo = repos[i]; | |||
There was a problem hiding this comment.
这个函数的名字比较奇怪，函数名字的意思是获取账号下已同步的资料库列表，但是返回的却是没有 token 的已同步资料库。然后看一下只被一个函数调用，就是为没有 token 的资料库重新获取一下 token。
这个函数有什么用呢？什么情况下可能出现有的已同步资料库没有设置 token 属性？这个 token 正常是在什么时候设置到底层的 repo 属性里面的呢？
There was a problem hiding this comment.
这个应该是重新登录账号时用来更新 token 的，token 最开始应该是在 clone repo 时设置的。一般情况下应该都有这个 token 属性的。
killing
reviewed
Feb 21, 2025
src/account-mgr.cpp
Outdated
| @@ -105,19 +105,22 @@ QStringList collectSyncedReposForAccount(const Account& account) | |||
| LocalRepo repo = repos[i]; | |||
There was a problem hiding this comment.
这个函数的名字改为 collectSyncedReposWithoutToken 吧。同时，位置移动到调用位置附近吧。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.