-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use importlib.metadata instead of reading pyproject.toml in init #250
Merged
hadialqattan
merged 6 commits into
hadialqattan:master
from
or150:bugfix/package-metadata-import
Jan 6, 2025
Merged
Use importlib.metadata instead of reading pyproject.toml in init #250
hadialqattan
merged 6 commits into
hadialqattan:master
from
or150:bugfix/package-metadata-import
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc01be0
to
c659866
Compare
@hadialqattan I think this should possibly go sooner, as many would disable |
Sorry for being late. |
c659866
to
b9c924e
Compare
Code Climate has analyzed commit 298c9b4 and detected 0 issues on this pull request. View more on Code Climate. |
5 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This change makes pre-commit usages work again and fixes issues #249, #228.
The root cause for the issue is poetry-core just released a version 2.0 that doesn't add the
pyproject.toml
file to the root ofsite-packages
, which I guess it wasn't there on purpose.It uses
importlib.metadata
instead of readingpyproject.toml
, which should be compatible with both versions of poetry-core.Thought about also changing build-system to:
WDYT?