Merge pull request #44 from hadashiA/ku/fix-lifetime-scope-registration

Make sure LifetimeScope can be resolve as base class
hadashiA · Nov 8, 2020 · 09b498c · 09b498c
2 parents 523450a + 29664db
commit 09b498c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/VContainer/Assets/VContainer/Runtime/Unity/LifetimeScope.cs b/VContainer/Assets/VContainer/Runtime/Unity/LifetimeScope.cs
@@ -216,7 +216,7 @@ void InstallTo(IContainerBuilder builder)
             }
             extraInstaller?.Install(builder);
 
-            builder.RegisterInstance(this);
+            builder.RegisterInstance<LifetimeScope>(this).AsSelf();
         }
 
         LifetimeScope GetRuntimeParent()

diff --git a/VContainer/Assets/VContainer/Tests/Unity/LifetimeScopeTest.cs b/VContainer/Assets/VContainer/Tests/Unity/LifetimeScopeTest.cs
@@ -6,6 +6,8 @@
 
 namespace VContainer.Tests.Unity
 {
+    class SampleLifetimeScope : LifetimeScope {}
+
     public class LifetimeScopeTest
     {
         [Test]
@@ -33,7 +35,8 @@ public IEnumerator CreateChild()
                 builder.RegisterEntryPoint<SampleEntryPoint>(Lifetime.Scoped).AsSelf();
             }))
             {
-                parentLifetimeScope = new GameObject("LifetimeScope").AddComponent<LifetimeScope>();
+                parentLifetimeScope = new GameObject("SampleLifetimeScope")
+                    .AddComponent<SampleLifetimeScope>();
             }
 
             yield return null;