-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : add basic unit test to the project #6
Conversation
The workflow should have The main problem is that go-harfbuzz is developed on a higher harfbuzz version than what Ubuntu's apt has. |
any suggestion for fix haefbuzz version in ubuntu? |
The best way I can think of is to lower go-harfbuzz's binding version. It means we just have to remove some features from it temporarily but still have them in another branch ready to release. I'll fix that tomorrow as soon as I find some free time. |
After doing a little bit more research, I found that harfbuzz versions on Ubuntu are so outdated (except Ubuntu 24.04) based on harfbuzz-versions So, there are two things we should do:
|
i change that to ubuntu 24.04 for now. Update: In order not to keep the pipeline broken until this PR is ready, I have done this in a separate PR #8. |
i am not finish work on unittest :) |
Oh... I'm so sorry... It's my first time managing PRs and doing reviews; So make a lot of mistakes. |
don't worry no problem. all of us has a starting point :) |
This PR try to add basic unit test to the project
@haashemi do you need any specific unit test?
work in progress this list will be update