Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add basic unit test to the project #6

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

Monirzadeh
Copy link
Contributor

@Monirzadeh Monirzadeh commented Jun 26, 2024

This PR try to add basic unit test to the project
@haashemi do you need any specific unit test?
work in progress this list will be update

  • add basic unit test include
    • font.go
  • add workflow to run test on any new PR

@Monirzadeh Monirzadeh marked this pull request as draft June 26, 2024 21:41
@Monirzadeh Monirzadeh marked this pull request as ready for review June 26, 2024 22:08
@haashemi
Copy link
Owner

The workflow should have gcc, pkg-config, and harfbuzz-dev installed.

The main problem is that go-harfbuzz is developed on a higher harfbuzz version than what Ubuntu's apt has.

@Monirzadeh
Copy link
Contributor Author

The workflow should have gcc, pkg-config, and harfbuzz-dev installed.

The main problem is that go-harfbuzz is developed on a higher harfbuzz version than what Ubuntu's apt has.

any suggestion for fix haefbuzz version in ubuntu?
regardless building that in workflow?

@haashemi
Copy link
Owner

any suggestion for fix harfbuzz version in ubuntu? regardless building that in workflow?

The best way I can think of is to lower go-harfbuzz's binding version. It means we just have to remove some features from it temporarily but still have them in another branch ready to release.

I'll fix that tomorrow as soon as I find some free time.

@haashemi
Copy link
Owner

After doing a little bit more research, I found that harfbuzz versions on Ubuntu are so outdated (except Ubuntu 24.04) based on harfbuzz-versions

So, there are two things we should do:

  1. Set the workflow runner to ubuntu-24.04 (which is beta)
  2. Change the go-harfbuzz bindings to support harfbuzz 8.3.0

@Monirzadeh
Copy link
Contributor Author

Monirzadeh commented Jun 27, 2024

i change that to ubuntu 24.04 for now.
if you think it is not a good idea we can work on second approach before merge this.

Update: In order not to keep the pipeline broken until this PR is ready, I have done this in a separate PR #8.

@haashemi haashemi merged commit 4c49f16 into haashemi:main Jun 27, 2024
2 checks passed
@Monirzadeh
Copy link
Contributor Author

i am not finish work on unittest :)
any way i will send another PR

@haashemi
Copy link
Owner

haashemi commented Jun 27, 2024

Oh... I'm so sorry...

It's my first time managing PRs and doing reviews; So make a lot of mistakes.

@Monirzadeh
Copy link
Contributor Author

don't worry no problem. all of us has a starting point :)

@Monirzadeh Monirzadeh deleted the unit-test branch June 27, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants