Skip to content

Commit

Permalink
Merge pull request #5 from Monirzadeh/fix-golangci-lint
Browse files Browse the repository at this point in the history
  • Loading branch information
haashemi authored Jun 26, 2024
2 parents bb4409f + bcceb8a commit 030253d
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
27 changes: 27 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Source: https://github.com/actions/starter-workflows/blob/main/ci/go.yml
name: CI

on:
push:
branches: [main]
pull_request:
branches: [main]

permissions:
contents: read

jobs:
# Test golangci-lint for go-version define in go.mod
golangci:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac #v4.0.0
- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe #v4.1.0
with:
go-version-file: go.mod
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc #v3.7.0
with:
version: latest
only-new-issues: true
5 changes: 4 additions & 1 deletion options.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ type Options struct {
// bidiText converts a bi-directional text logically to visually.
func bidiText(in string) (out string, err error) {
p := bidi.Paragraph{}
p.SetString(in)
_, err = p.SetString(in)
if err != nil {
return
}

o, err := p.Order()
if err != nil {
Expand Down

0 comments on commit 030253d

Please sign in to comment.