Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about clang-format version #91

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Be more explicit about clang-format version #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc592eb
Be more explicit about clang-format version
EmilyBourne Feb 12, 2025
903424c
Fall back to clang-format if v14 is not available
EmilyBourne Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bin/indent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,18 @@ else
RUN_IF_OK='true'
fi

CLANG_FORMAT=clang-format
if [ "$(hostname)" == "persee.partenaires.cea.fr" ]
then
CLANG_FORMAT=/data/gyselarunner/clang-format
Comment on lines 72 to 74
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to expose this ? @gdgirard

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that it is a good idea.

else
CLANG_FORMAT=clang-format-14
set +e
if ! command -v ${CLANG_FORMAT} 2>&1 >/dev/null
then
CLANG_FORMAT=clang-format
echo "Could not find clang-format v14. Clang-formatting may not behave as expected"
fi
set -e
fi

${DOCKER_COMMAND} find \
Expand Down
Loading