Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create redirects to enforce proper sequence #17

Open
dolsysmith opened this issue Sep 22, 2022 · 2 comments
Open

Create redirects to enforce proper sequence #17

dolsysmith opened this issue Sep 22, 2022 · 2 comments
Milestone
1.0

Comments

@dolsysmith
Copy link
Collaborator

dolsysmith commented Sep 22, 2022 •
edited
Loading

It's possible that a user will end up at the /orcid endpoint without first having visited/?sso. This will initiate the ORCID authentication step without the presence of SAML data, leading to an error when the app tries to save the ORCID tokens to the database.

We should check for the presence of SAML attributes in the session object and redirect to /?sso if absent.
@kilahimm kilahimm added this to the 1.0 milestone Oct 4, 2022
@dolsysmith
Copy link
Collaborator Author

This should be fixed now.

@dolsysmith
Copy link
Collaborator Author

Where should we redirect the user at the end of the SSO logout process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@kilahimm @dolsysmith