Analytics: Recognize extension combat state change as extension event

gw2scratch · Jul 8, 2024 · cbe10a0 · cbe10a0
1 parent ce1a2bc
commit cbe10a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/EVTCAnalytics/Parsing/CombatItemFilters.cs b/EVTCAnalytics/Parsing/CombatItemFilters.cs
@@ -279,7 +279,7 @@ private static IEnumerable<StateChange> GetDirectStateChangesForEventType(Type e
 		// so we need to return all of them.
 		Debug.Assert(Enum.GetUnderlyingType(typeof(StateChange)) == typeof(byte));
 		if (eventType == typeof(UnknownEvent)) return Enumerable.Range(0, 256).Select(x => (StateChange) x);
-		if (eventType == typeof(UnknownExtensionEvent)) return [StateChange.Extension];
+		if (eventType == typeof(UnknownExtensionEvent)) return [StateChange.Extension, StateChange.ExtensionCombat];
 
 		throw new ArgumentException($"Event type {eventType} is not supported.");
 	}

diff --git a/EVTCAnalytics/Processing/LogProcessor.cs b/EVTCAnalytics/Processing/LogProcessor.cs
@@ -1195,8 +1195,8 @@ static WeaponSet WeaponSetFromId(long id)
 					case StateChange.IdleEvent:
 						return new UnknownEvent(item.Time, item);
 					case StateChange.ExtensionCombat:
-						// Not sure if this ever appears in logs.
-						return new UnknownEvent(item.Time, item);
+						// Same as StateChange.Extension, but skillid is treated as skill and added to the skill table.
+						return new UnknownExtensionEvent(item.Time, item);
 					case StateChange.Effect2:
 					{
 						// Official docs as of 2023-07-18: