Skip to content

Commit

Permalink
SKA: Fix kebab-case issues in obs-ux-logs packages (elastic#211347)
Browse files Browse the repository at this point in the history
## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 1 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/logs-overview` | `x-pack/platform/packages/shared/logs-overview`
|

<details >
<summary>Updated references</summary>

```
./package.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/private/kbn-repo-packages/package-map.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/packages/shared/logs-overview/jest.config.js
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
x-pack/platform/packages/shared/logs-overview/jest.config.js:10
x-pack/platform/packages/shared/logs-overview/tsconfig.json:2
```

</details>

(cherry picked from commit 0ecbbd5)

# Conflicts:
#	package.json
#	tsconfig.base.json
#	yarn.lock
  • Loading branch information
gsoldevila committed Feb 17, 2025
1 parent 4aaf263 commit 17b9581
Show file tree
Hide file tree
Showing 50 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common @elastic/respon
x-pack/platform/packages/shared/kbn-key-value-metadata-table @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team
x-pack/platform/packages/shared/kbn-langchain @elastic/security-generative-ai
x-pack/platform/packages/shared/kbn-slo-schema @elastic/obs-ux-management-team
x-pack/platform/packages/shared/logs_overview @elastic/obs-ux-logs-team
x-pack/platform/packages/shared/logs-overview @elastic/obs-ux-logs-team
x-pack/platform/packages/shared/ml/aiops_common @elastic/ml-ui
x-pack/platform/packages/shared/ml/aiops_log_pattern_analysis @elastic/ml-ui
x-pack/platform/packages/shared/ml/aiops_log_rate_analysis @elastic/ml-ui
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@
"@kbn/logging-mocks": "link:src/platform/packages/shared/kbn-logging-mocks",
"@kbn/logs-data-access-plugin": "link:x-pack/platform/plugins/shared/logs_data_access",
"@kbn/logs-explorer-plugin": "link:x-pack/solutions/observability/plugins/logs_explorer",
"@kbn/logs-overview": "link:x-pack/platform/packages/shared/logs_overview",
"@kbn/logs-overview": "link:x-pack/platform/packages/shared/logs-overview",
"@kbn/logs-shared-plugin": "link:x-pack/platform/plugins/shared/logs_shared",
"@kbn/logstash-plugin": "link:x-pack/platform/plugins/private/logstash",
"@kbn/managed-content-badge": "link:src/platform/packages/private/kbn-managed-content-badge",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1188,8 +1188,8 @@
"@kbn/logs-data-access-plugin/*": ["x-pack/platform/plugins/shared/logs_data_access/*"],
"@kbn/logs-explorer-plugin": ["x-pack/solutions/observability/plugins/logs_explorer"],
"@kbn/logs-explorer-plugin/*": ["x-pack/solutions/observability/plugins/logs_explorer/*"],
"@kbn/logs-overview": ["x-pack/platform/packages/shared/logs_overview"],
"@kbn/logs-overview/*": ["x-pack/platform/packages/shared/logs_overview/*"],
"@kbn/logs-overview": ["x-pack/platform/packages/shared/logs-overview"],
"@kbn/logs-overview/*": ["x-pack/platform/packages/shared/logs-overview/*"],
"@kbn/logs-shared-plugin": ["x-pack/platform/plugins/shared/logs_shared"],
"@kbn/logs-shared-plugin/*": ["x-pack/platform/plugins/shared/logs_shared/*"],
"@kbn/logstash-plugin": ["x-pack/platform/plugins/private/logstash"],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"xpack.observability_onboarding": "solutions/observability/plugins/observability_onboarding",
"xpack.observabilityShared": "solutions/observability/plugins/observability_shared",
"xpack.observabilityLogsOverview": [
"platform/packages/shared/logs_overview/src/components"
"platform/packages/shared/logs-overview/src/components"
],
"xpack.osquery": [
"platform/plugins/shared/osquery"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/platform/packages/shared/logs_overview'],
roots: ['<rootDir>/x-pack/platform/packages/shared/logs-overview'],
};
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6245,7 +6245,7 @@
version "0.0.0"
uid ""

"@kbn/logs-overview@link:x-pack/platform/packages/shared/logs_overview":
"@kbn/logs-overview@link:x-pack/platform/packages/shared/logs-overview":
version "0.0.0"
uid ""

Expand Down

0 comments on commit 17b9581

Please sign in to comment.