Fix dropdown floating portals #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8771ffe The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for igloo-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alexasselin008
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
DS-540
EP-3989
In OV, we have run into an issue where floating portals occasionally do not open. This was thought to be isolated to one component in OV so a workaround was #856. This worked for the once case but now that the bug has been seen elsewhere, we would like to fix it for all floating portals to prevent the issue popping back up elsewhere. I believe the latest updates to floating-ui include fixes for the portal IDs that may fix the issue, so updating these packages and then updating our references to igloo should fix the issue.
Thanks @PatrickDeVries for raising the issue and opening the initial PR.
Example of the issue in an ActionMenu: