From 167f08c98fb4ab3d9ff1b156807e7998004d2c12 Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Fri, 12 Apr 2024 15:05:01 -0400 Subject: [PATCH 01/10] update_workflows --- .github/workflows/chromatic.yml | 81 ++++++++------ .github/workflows/ci.yml | 50 +++++---- .github/workflows/publish.yml | 180 +++++++------------------------- 3 files changed, 118 insertions(+), 193 deletions(-) diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml index a3e3810c..23b2aeda 100644 --- a/.github/workflows/chromatic.yml +++ b/.github/workflows/chromatic.yml @@ -1,37 +1,56 @@ -name: 'Chromatic' +# Chromatic Main and Active PRs only +# Trigger example found here: https://github.com/chromaui/chromatic-cli/blob/main/.github/workflows/chromatic-main-and-prs.yml + +name: Chromatic on: push: - paths: - - 'packages/**' - branches-ignore: + branches: - main - - dependabot/* - - changeset-release/* + pull_request: + # Workflows will not run on pull_request activity if the pull request has a merge conflict. The merge conflict must be resolved first. + # By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened. + branches-ignore: + - changeset-release/* + - dependabot/* jobs: - chromatic-deployment: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - with: - fetch-depth: 0 - - name: Use Node.js 18.x - uses: actions/setup-node@v2 - with: - node-version: '18.x' - - name: Cache Node.js modules - uses: actions/cache@v2 - with: - path: ~/.npm - key: ${{ runner.OS }}-node-${{ hashFiles('**/yarn.lock')}} - restore-keys: | - ${{ runner.OS }}-node- - ${{ runner.OS }}- - - run: yarn install --frozen-lockfile - - run: yarn build - - name: Publish to Chromatic - uses: chromaui/action@v1 - with: - token: ${{ secrets.CHROMATIC_TOKEN }} - projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} + chromatic-deployment: + runs-on: ubuntu-latest + permissions: + contents: write + pull-requests: write + steps: + - name: Checkout Commit + uses: actions/checkout@v3 + with: + fetch-depth: 0 + + - name: Install Node.js + uses: actions/setup-node@v3 + with: + node-version-file: ".nvmrc" + + - name: Cache Node.js modules + uses: actions/cache@v3 + with: + path: ~/.npm + key: ${{ runner.OS }}-node-${{ hashFiles('**/yarn.lock')}} + restore-keys: | + ${{ runner.OS }}-node- + ${{ runner.OS }}- + + - name: Install dependencies + run: yarn install --frozen-lockfile + + - name: Build Packages + run: yarn build + + - name: Publish to Chromatic + uses: chromaui/action@v1 + with: + projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} + traceChanged: true + onlyChanged: true # TurboSnap + exitOnceUploaded: true # The PRs will be marked as success/failure based on the Chromatic build status + skip: ${{ github.event.pull_request.draft == true }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fc16b890..cf308a18 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,16 +11,15 @@ concurrency: jobs: install-cache: runs-on: ubuntu-latest - strategy: - matrix: - node-version: [ 18 ] steps: - name: Checkout Commit uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node }} + + - name: Install Node.js uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node }} + node-version-file: ".nvmrc" + - name: Cache yarn dependencies uses: actions/cache@v3 id: cache-dependencies @@ -28,7 +27,8 @@ jobs: path: node_modules key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} restore-keys: | - ${{ runner.ox }}-yarn- + ${{ runner.os }}-yarn- + - name: Install Dependencies if: steps.cache-dependencies.outputs.cache-hit != 'true' run: | @@ -36,17 +36,16 @@ jobs: lint: runs-on: ubuntu-latest - strategy: - matrix: - node-version: [ 18 ] needs: install-cache steps: - name: Checkout Commit uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node }} + + - name: Install Node.js uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node }} + node-version-file: ".nvmrc" + - name: Restore yarn dependencies uses: actions/cache@v3 id: cache-dependencies @@ -54,9 +53,11 @@ jobs: path: node_modules key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} restore-keys: | - ${{ runner.ox }}-yarn- + ${{ runner.os }}-yarn- + - name: Run Eslint run: yarn lint + - name: Run Stylelint run: yarn lint:style @@ -69,10 +70,12 @@ jobs: steps: - name: Checkout Commit uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node }} + + - name: Install Node.js uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node }} + node-version-file: ".nvmrc" + - name: Restore yarn dependencies uses: actions/cache@v3 id: cache-dependencies @@ -80,27 +83,29 @@ jobs: path: node_modules key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} restore-keys: | - ${{ runner.ox }}-yarn- + ${{ runner.os }}-yarn- + - name: Run build Shared components run: yarn build:shared + - name: Run build Components run: yarn build:components + - name: Run tests run: yarn test build_doc: runs-on: ubuntu-latest - strategy: - matrix: - node-version: [ 18 ] needs: [install-cache, build_and_test_components] steps: - name: Checkout Commit uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node }} + + - name: Install Node.js uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node }} + node-version-file: ".nvmrc" + - name: Restore yarn dependencies uses: actions/cache@v3 id: cache-dependencies @@ -108,7 +113,8 @@ jobs: path: node_modules key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} restore-keys: | - ${{ runner.ox }}-yarn- + ${{ runner.os }}-yarn- + - name: Run build Doc run: yarn doc:build @@ -134,4 +140,4 @@ jobs: } env: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK \ No newline at end of file + SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index d5a43a12..e53017e3 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -5,143 +5,43 @@ on: branches: [main] jobs: - install-cache: - runs-on: ubuntu-latest - strategy: - matrix: - node-version: [ 18 ] - steps: - - name: Checkout Commit - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node }} - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node }} - - name: Cache yarn dependencies - uses: actions/cache@v3 - id: cache-dependencies - with: - path: node_modules - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.ox }}-yarn- - - name: Install Dependencies - if: steps.cache-dependencies.outputs.cache-hit != 'true' - run: | - yarn install --force --non-interactive - - lint: - name: Lint - runs-on: ubuntu-latest - strategy: - matrix: - node-version: [ 18 ] - needs: install-cache - steps: - - name: Checkout Commit - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node }} - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node }} - - name: Restore yarn dependencies - uses: actions/cache@v3 - id: cache-dependencies - with: - path: node_modules - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.ox }}-yarn- - - name: Run Eslint - run: yarn lint - - name: Run Stylelint - run: yarn lint:style - - test_and_build: - name: Test and build - runs-on: ubuntu-latest - strategy: - matrix: - node-version: [ 18 ] - needs: install-cache - steps: - - name: Checkout Commit - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node }} - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node }} - - name: Restore yarn dependencies - uses: actions/cache@v3 - id: cache-dependencies - with: - path: node_modules - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.ox }}-yarn- - - name: Run build - run: yarn build - - name: Run tests - run: yarn test - - release: - name: Release - needs: [test_and_build] - runs-on: ubuntu-latest - permissions: - id-token: write - contents: write - pull-requests: write - - strategy: - matrix: - node-version: [ 18 ] - - steps: - - name: Checkout Commit - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node }} - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node }} - - name: Restore yarn dependencies - uses: actions/cache@v3 - id: cache-dependencies - with: - path: node_modules - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.ox }}-yarn- - - name: Create Release Pull Request or Publish to npm - id: changesets - uses: changesets/action@v1 - env: - GITHUB_TOKEN: ${{ secrets.github_token }} - - publish-npm: - name: Publish to npm - needs: [test_and_build] - runs-on: ubuntu-latest - strategy: - matrix: - node-version: [ 18 ] - - steps: - - name: Checkout Commit - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node }} - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node }} - registry-url: https://registry.npmjs.org/ - - name: Restore yarn dependencies - uses: actions/cache@v3 - id: cache-dependencies - with: - path: node_modules - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.ox }}-yarn- - - run: yarn publish-ci - env: - NODE_AUTH_TOKEN: ${{secrets.npm_token}} + version: + runs-on: ubuntu-latest + permissions: + id-token: write # required for provenance https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions + contents: write + pull-requests: write + + steps: + - name: Checkout + uses: actions/checkout@v3 + + + - name: Install Node.js + uses: actions/setup-node@v3 + with: + node-version-file: ".nvmrc" + + - name: Cache yarn dependencies + uses: actions/cache@v3 + id: cache-dependencies + with: + path: node_modules + key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} + restore-keys: | + ${{ runner.os }}-yarn- + + - name: Install Dependencies + if: steps.cache-dependencies.outputs.cache-hit != 'true' + run: | + yarn install --force --non-interactive + + - name: Create release Pull Request or publish to NPM + uses: changesets/action@v1 + with: + commit: "ci(changesets): version packages" + title: "Changeset: New Version" + publish: yarn publish-ci + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + NPM_TOKEN: ${{ secrets.npm_token }} From 48d919ce3f2fc3125609715100901b65850b44fd Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Fri, 12 Apr 2024 15:37:22 -0400 Subject: [PATCH 02/10] update publish workflow --- .github/workflows/publish.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index e53017e3..c5fe53a6 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -45,3 +45,4 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} NPM_TOKEN: ${{ secrets.npm_token }} + NODE_AUTH_TOKEN: ${{ secrets.npm_token }} From 444208feccdeee08ec0917510d26124b0a430a66 Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Fri, 12 Apr 2024 15:54:00 -0400 Subject: [PATCH 03/10] Remove chromatic from package.json --- package.json | 2 -- yarn.lock | 5 ----- 2 files changed, 7 deletions(-) diff --git a/package.json b/package.json index 4ce61f4a..64025d09 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,6 @@ "build-storybook": "storybook build", "prepublish-ci": "yarn build", "publish-ci": "npx lerna publish from-package -y", - "chromatic": "npx chromatic --project-token=CHROMATIC_PROJECT_TOKEN --only-changed", "bootstrap": "node utils/bootstrap/component.mjs && npx lerna bootstrap && yarn fix:all" }, "workspaces": [ @@ -77,7 +76,6 @@ "babel-jest": "29.6.2", "babel-loader": "9.1.3", "camelcase": "6.3.0", - "chromatic": "^11.3.0", "eslint": "8.53.0", "eslint-config-airbnb": "19.0.4", "eslint-config-prettier": "8.10.0", diff --git a/yarn.lock b/yarn.lock index 05619199..4d285675 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8876,11 +8876,6 @@ chownr@^2.0.0: resolved "https://registry.yarnpkg.com/chownr/-/chownr-2.0.0.tgz#15bfbe53d2eab4cf70f18a8cd68ebe5b3cb1dece" integrity sha512-bIomtDF5KGpdogkLd9VspvFzk9KfpyyGlS8YFVZl7TGPBHL5snIOnxeshwVgPteQ9b4Eydl+pVbIyE1DcvCWgQ== -chromatic@^11.3.0: - version "11.3.0" - resolved "https://registry.yarnpkg.com/chromatic/-/chromatic-11.3.0.tgz#d46b7aac1a0eaed29a765645eaf93c484220174c" - integrity sha512-q1ZtJDJrjLGnz60ivpC16gmd7KFzcaA4eTb7gcytCqbaKqlHhCFr1xQmcUDsm14CK7JsqdkFU6S+JQdOd2ZNJg== - chrome-trace-event@^1.0.2: version "1.0.3" resolved "https://registry.yarnpkg.com/chrome-trace-event/-/chrome-trace-event-1.0.3.tgz#1015eced4741e15d06664a957dbbf50d041e26ac" From 6e94aa5bc66869524a6de3dc28e23f4c1a6f23f4 Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Fri, 12 Apr 2024 16:00:27 -0400 Subject: [PATCH 04/10] now skip docs build in chromatic workflow --- .github/workflows/chromatic.yml | 7 +++++-- .github/workflows/publish.yml | 1 - 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml index 23b2aeda..ccb3b0f3 100644 --- a/.github/workflows/chromatic.yml +++ b/.github/workflows/chromatic.yml @@ -43,8 +43,11 @@ jobs: - name: Install dependencies run: yarn install --frozen-lockfile - - name: Build Packages - run: yarn build + - name: Run build Shared components + run: yarn build:shared + + - name: Run build Components + run: yarn build:components - name: Publish to Chromatic uses: chromaui/action@v1 diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c5fe53a6..e4558e63 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -16,7 +16,6 @@ jobs: - name: Checkout uses: actions/checkout@v3 - - name: Install Node.js uses: actions/setup-node@v3 with: From b9ffae5f294bd0a25715bad2b216f42f3680f733 Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Fri, 12 Apr 2024 16:02:03 -0400 Subject: [PATCH 05/10] Revert "Remove chromatic from package.json" This reverts commit 444208feccdeee08ec0917510d26124b0a430a66. --- package.json | 2 ++ yarn.lock | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/package.json b/package.json index 64025d09..4ce61f4a 100644 --- a/package.json +++ b/package.json @@ -27,6 +27,7 @@ "build-storybook": "storybook build", "prepublish-ci": "yarn build", "publish-ci": "npx lerna publish from-package -y", + "chromatic": "npx chromatic --project-token=CHROMATIC_PROJECT_TOKEN --only-changed", "bootstrap": "node utils/bootstrap/component.mjs && npx lerna bootstrap && yarn fix:all" }, "workspaces": [ @@ -76,6 +77,7 @@ "babel-jest": "29.6.2", "babel-loader": "9.1.3", "camelcase": "6.3.0", + "chromatic": "^11.3.0", "eslint": "8.53.0", "eslint-config-airbnb": "19.0.4", "eslint-config-prettier": "8.10.0", diff --git a/yarn.lock b/yarn.lock index 4d285675..05619199 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8876,6 +8876,11 @@ chownr@^2.0.0: resolved "https://registry.yarnpkg.com/chownr/-/chownr-2.0.0.tgz#15bfbe53d2eab4cf70f18a8cd68ebe5b3cb1dece" integrity sha512-bIomtDF5KGpdogkLd9VspvFzk9KfpyyGlS8YFVZl7TGPBHL5snIOnxeshwVgPteQ9b4Eydl+pVbIyE1DcvCWgQ== +chromatic@^11.3.0: + version "11.3.0" + resolved "https://registry.yarnpkg.com/chromatic/-/chromatic-11.3.0.tgz#d46b7aac1a0eaed29a765645eaf93c484220174c" + integrity sha512-q1ZtJDJrjLGnz60ivpC16gmd7KFzcaA4eTb7gcytCqbaKqlHhCFr1xQmcUDsm14CK7JsqdkFU6S+JQdOd2ZNJg== + chrome-trace-event@^1.0.2: version "1.0.3" resolved "https://registry.yarnpkg.com/chrome-trace-event/-/chrome-trace-event-1.0.3.tgz#1015eced4741e15d06664a957dbbf50d041e26ac" From 54c7ca43612389cced51ea911d9a328325e1c6dd Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Fri, 12 Apr 2024 16:19:58 -0400 Subject: [PATCH 06/10] turbosnap test --- packages/Button/src/button.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/Button/src/button.scss b/packages/Button/src/button.scss index fd604e92..06722ffc 100644 --- a/packages/Button/src/button.scss +++ b/packages/Button/src/button.scss @@ -23,7 +23,7 @@ --ids-focus-shadow: #{tokens.$focus}; /* Primary */ - --ids-btn-text-primary: #{tokens.$samoyed}; + --ids-btn-text-primary: red; --ids-btn-text-primary-disabled: #{tokens.$samoyed}; --ids-btn-text-primary-active: #{tokens.$electric-blue-500}; --ids-btn-border-primary: transparent; @@ -137,7 +137,7 @@ --ids-focus-shadow: 0 0 0 0.12rem var(--hop-neutral-surface), 0 0 0 0.219rem var(--hop-primary-border-focus); /* Primary */ - --ids-btn-text-primary: var(--hop-primary-text-strong); + --ids-btn-text-primary: green; --ids-btn-text-primary-disabled: var(--hop-neutral-text-disabled); --ids-btn-text-primary-active: var(--hop-primary-text-active); --ids-btn-border-primary: transparent; From 26509943366324ea9337412fed5ea4feacd30ddd Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Fri, 12 Apr 2024 16:27:29 -0400 Subject: [PATCH 07/10] Update CI workflow to prevent build duplication. build_doc used to rebuild all the components, after they were just built --- .github/workflows/ci.yml | 39 ++++++--------------------------------- package.json | 3 ++- 2 files changed, 8 insertions(+), 34 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cf308a18..6e9070ec 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -61,11 +61,8 @@ jobs: - name: Run Stylelint run: yarn lint:style - build_and_test_components: + build_and_test: runs-on: ubuntu-latest - strategy: - matrix: - node-version: [ 18 ] needs: install-cache steps: - name: Checkout Commit @@ -85,42 +82,18 @@ jobs: restore-keys: | ${{ runner.os }}-yarn- - - name: Run build Shared components - run: yarn build:shared - - - name: Run build Components - run: yarn build:components + - name: Run build + run: yarn build - name: Run tests run: yarn test - build_doc: - runs-on: ubuntu-latest - needs: [install-cache, build_and_test_components] - steps: - - name: Checkout Commit - uses: actions/checkout@v3 - - - name: Install Node.js - uses: actions/setup-node@v3 - with: - node-version-file: ".nvmrc" - - - name: Restore yarn dependencies - uses: actions/cache@v3 - id: cache-dependencies - with: - path: node_modules - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.os }}-yarn- - - - name: Run build Doc - run: yarn doc:build + - name: Run Documentation Storybook + run: yarn doc:build-sb slack-notification: runs-on: ubuntu-latest - needs: [build_and_test_components, build_doc, lint] + needs: [build_and_test, lint] steps: - name: Send message to Slack id: slack diff --git a/package.json b/package.json index 4ce61f4a..015944af 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,8 @@ "lint:all": "yarn lint && yarn lint:style", "fix:all": "yarn lint:fix && yarn fix:style", "doc:start": "lerna run dev --scope=docs", - "doc:build": "lerna run build --verbose --scope=docs && yarn build-storybook --docs -o ./website/.next/storybook", + "doc:build": "lerna run build --verbose --scope=docs && yarn doc:build-sb", + "doc:build-sb":"yarn build-storybook --docs -o ./website/.next/storybook", "dev": "yarn build:shared && yarn build:components && yarn storybook", "storybook": "storybook dev -p 6006", "build-storybook": "storybook build", From 9a6e0023f99cab3aa75f025200b54a3e518c649b Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Fri, 12 Apr 2024 16:32:41 -0400 Subject: [PATCH 08/10] Revert "turbosnap test" This reverts commit 54c7ca43612389cced51ea911d9a328325e1c6dd. --- packages/Button/src/button.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/Button/src/button.scss b/packages/Button/src/button.scss index 06722ffc..fd604e92 100644 --- a/packages/Button/src/button.scss +++ b/packages/Button/src/button.scss @@ -23,7 +23,7 @@ --ids-focus-shadow: #{tokens.$focus}; /* Primary */ - --ids-btn-text-primary: red; + --ids-btn-text-primary: #{tokens.$samoyed}; --ids-btn-text-primary-disabled: #{tokens.$samoyed}; --ids-btn-text-primary-active: #{tokens.$electric-blue-500}; --ids-btn-border-primary: transparent; @@ -137,7 +137,7 @@ --ids-focus-shadow: 0 0 0 0.12rem var(--hop-neutral-surface), 0 0 0 0.219rem var(--hop-primary-border-focus); /* Primary */ - --ids-btn-text-primary: green; + --ids-btn-text-primary: var(--hop-primary-text-strong); --ids-btn-text-primary-disabled: var(--hop-neutral-text-disabled); --ids-btn-text-primary-active: var(--hop-primary-text-active); --ids-btn-border-primary: transparent; From 78e27595c7550bd34d6971d26dcb10dcbe844ed2 Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Fri, 12 Apr 2024 16:39:09 -0400 Subject: [PATCH 09/10] add build step to release step --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index e4558e63..cc6440d6 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -40,7 +40,7 @@ jobs: with: commit: "ci(changesets): version packages" title: "Changeset: New Version" - publish: yarn publish-ci + publish: yarn build && yarn publish-ci env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} NPM_TOKEN: ${{ secrets.npm_token }} From 826d97e9b035649d21aacb287d71e8af92411847 Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Mon, 15 Apr 2024 08:37:32 -0400 Subject: [PATCH 10/10] change the install step so it doesn't create a new lockfile when releasing --- .github/workflows/ci.yml | 2 +- .github/workflows/publish.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6e9070ec..1111e15d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,7 +32,7 @@ jobs: - name: Install Dependencies if: steps.cache-dependencies.outputs.cache-hit != 'true' run: | - yarn install --force --non-interactive + yarn install --frozen-lockfile lint: runs-on: ubuntu-latest diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index cc6440d6..9815e544 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -33,7 +33,7 @@ jobs: - name: Install Dependencies if: steps.cache-dependencies.outputs.cache-hit != 'true' run: | - yarn install --force --non-interactive + yarn install --frozen-lockfile - name: Create release Pull Request or publish to NPM uses: changesets/action@v1