Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Workflows #788

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Update Workflows #788

merged 10 commits into from
Apr 15, 2024

Conversation

alexasselin008
Copy link
Member

@alexasselin008 alexasselin008 commented Apr 12, 2024

Modified chromatic.yml workflow

  • Changed trigger for suggested chromatic triggers
  • updated actions/setup-node actions/cache and actions/checkout to v3
  • now use the .nvmrc file to dictate node version
  • added turbosnap
  • Now only build shared and components, skipping the docs. This improves the workflow executionby like 2mins

Modified publish.yml

  • now use the .nvmrc file to dictate node version
  • cache@v3's restore key had a typo inside it (runner.ox instead of .os)
  • Since the publish action is done on main, and main is always buildable / linted properly, i've removed the build / lint / test step. This improves the workflow execution by at least 5 minutes

Modified ci.yml

  • now use the .nvmrc file to dictate node version
  • cache@v3's restore key had a typo inside it (runner.ox instead of .os)
  • The step build_doc was intended to only build the documentation website + storybook, but was rebuilding all the components. I merged build_and_test_components and build_doc to remove the build duplication

Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: 826d97e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for igloo-ui ready!

Name Link
🔨 Latest commit 826d97e
🔍 Latest deploy log https://app.netlify.com/sites/igloo-ui/deploys/661d1f9df02f910008f1cb95
😎 Deploy Preview https://deploy-preview-788--igloo-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member Author

@alexasselin008 alexasselin008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chromatic seems to build the documentation website. We should optimize that, this is not needed

franckgaudin
franckgaudin previously approved these changes Apr 12, 2024
.github/workflows/publish.yml Outdated Show resolved Hide resolved
@alexasselin008 alexasselin008 merged commit fa57ac7 into main Apr 15, 2024
12 checks passed
@alexasselin008 alexasselin008 deleted the feature/test_chromatic branch April 15, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants