Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/777 #784

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Feature/777 #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1ec2d3
updated hopper tokens - UI adjustement to Breadcrumb for WL theme
fraincs Apr 10, 2024
d58105f
updated breadrcumbs snapshots
fraincs Apr 10, 2024
3c501c6
changeset
fraincs Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/empty-parrots-help.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@igloo-ui/breadcrumb": patch
---

Fix UI issue
2 changes: 1 addition & 1 deletion packages/ActionMenu/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@igloo-ui/tokens": "^2.0.0",
"@igloo-ui/dropdown": "^1.8.1",
"@igloo-ui/list": "^0.7.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/Alert/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/icons-react16": "1.2.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/AreaChart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"luxon": "^3.4.4",
"recharts": "^2.12.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/Avatar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/BarChart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"framer-motion": "^6.5.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/Breadcrumb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"@igloo-ui/icons": "^1.12.2"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/Breadcrumb/src/Breadcrumb.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ const Breadcrumb: React.FunctionComponent<BreadcrumbProps> = ({
{displayLabel}
</a>
) : (
displayLabel
<span className="ids-breadcrumb__text">
{displayLabel}
</span>
)}

{!isBackLink && !current && (
Expand Down
6 changes: 5 additions & 1 deletion packages/Breadcrumb/src/__snapshots__/Breadcrumb.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ exports[`Breadcrumb It should render without error and a snapshot 1`] = `
aria-current="page"
class="ids-breadcrumb__item ids-breadcrumb__item--current"
>
Developer
<span
class="ids-breadcrumb__text"
>
Developer
</span>
</li>
</ol>
</nav>
Expand Down
32 changes: 32 additions & 0 deletions packages/Breadcrumb/src/breadcrumb.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
/* Chevron */
--ids-breadcrumb-chevron-color: #{tokens.$grey-800};
--ids-breadcrumb-chevron-spacing: 0 #{tokens.$space-2};
--ids-breadcrumb-chevron-dimension: auto;
}

[data-brand="workleap"] {
Expand All @@ -52,6 +53,7 @@
/* Chevron */
--ids-breadcrumb-chevron-color:var(--hop-neutral-icon-weak);
--ids-breadcrumb-chevron-spacing: 0 var(--hop-space-inline-sm);
--ids-breadcrumb-chevron-dimension: 0.75rem;
}

.ids-breadcrumb {
Expand All @@ -72,6 +74,7 @@

.ids-breadcrumb__item {
color: var(--ids-breadcrumb-item-color);
display: flex;
flex: 0 0 auto;

.ids-breadcrumb__link {
Expand All @@ -97,13 +100,42 @@
}
}

&.ids-breadcrumb__item--current {
min-height: 0.75rem;
}

.ids-breadcrumb__chevron {
color: var(--ids-breadcrumb-chevron-color);
height: var(--ids-breadcrumb-chevron-dimension);
margin: var(--ids-breadcrumb-chevron-spacing);
width: var(--ids-breadcrumb-chevron-dimension)
}

.ids-breadcrumb__item--is-back-link .ids-breadcrumb__chevron {
margin-left: 0;
}
}
}

[data-brand="workleap"] {
.ids-breadcrumb__item--current .ids-breadcrumb__text,
.ids-breadcrumb__link {
&::after,
&::before {
content: "";
display: block;
height: 0;
width: 0;
}

&::after {
margin-top: var(--hop-overline-top-offset);
}

&::before {
// 0.03125rem is to micro adjust the alignment of the text relative to the icon
/* stylelint-disable-next-line number-max-precision */
margin-bottom: calc(var(--hop-overline-bottom-offset) + 0.03125rem);
}
}
}
2 changes: 1 addition & 1 deletion packages/Button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/ButtonGroup/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Card/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Carousel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/Checkbox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Color/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/ColorPicker/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@igloo-ui/color": "^0.5.0",
"@igloo-ui/dropdown": "^1.8.1",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"react-aria": "^3.32.1",
"react-aria-components": "^1.1.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/Combobox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@igloo-ui/input": "^2.2.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/icons-react16": "1.2.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"@igloo-ui/tooltip": "^3.5.1",
"classnames": "^2.3.2"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/Datepicker/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@igloo-ui/icon-button": "^1.2.6",
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"@internationalized/date": "^3.5.2",
"classnames": "^2.3.2",
"luxon": "^3.4.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/Disclosure/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"framer-motion": "^6.5.1",
"react-aria": "^3.32.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/Dropdown/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@floating-ui/react": "^0.24.8",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Ellipsis/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Filter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/FormGroup/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@igloo-ui/icons": "^1.12.2",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"@igloo-ui/helper-text": "^0.3.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/HelperText/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Hyperlink/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"@react-aria/link": "^3.6.5",
"classnames": "^2.3.2"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/IconButton/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@igloo-ui/button": "^0.8.5",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/Input/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"graphemer": "^1.4.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/List/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/icons-react16": "1.2.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/Metric/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@igloo-ui/tooltip": "^3.5.1",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"react-aria": "^3.32.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/Modal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/icons-react16": "1.2.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"@igloo-ui/carousel": "^0.3.2",
"@types/react-dom": "18.0.11",
"classnames": "^2.3.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/OptionButton/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Pager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"@igloo-ui/icons": "^1.12.2"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/PieChart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"recharts": "^2.9.2"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/Popover/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@igloo-ui/icon-button": "^1.2.5",
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2",
"@floating-ui/react": "^0.26.9"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/ProgressBar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"classnames": "^2.3.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/Provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.5",
"@hopper-ui/tokens": "^3.5.0",
"react-aria": "^3.32.1"
},
"browserslist": [
Expand Down
Loading
Loading