Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: AreaChart - Error when all scores are null #580

Closed
LaurentDario opened this issue Nov 30, 2023 · 1 comment · Fixed by #581
Closed

[Bug]: AreaChart - Error when all scores are null #580

LaurentDario opened this issue Nov 30, 2023 · 1 comment · Fixed by #581
Labels
bug Something isn't working in backlog Pull requests for chore team

Comments

@LaurentDario
Copy link

LaurentDario commented Nov 30, 2023 •
edited
Loading

Contact Details

laurent.jouanneau@gsoft.com

What happened?

When the data set used in the AreaChart has only null scores, the graph errors out instead of displaying an empty graph. This is problematic in our usage of the component.
image

Component

AreaChart

Component Version

1.0.1

Which browsers are you seeing the problem on?

Chrome

Mobile Device

No response

Relevant log output

Error: Cannot read properties of undefined (reading 'score')
  at Array.map (<anonymous>))
  at getFakeScore (/storybook/AreaChart-stories.b3ee9eb1.iframe.bundle.js:1:20553))
  at /storybook/AreaChart-stories.b3ee9eb1.iframe.bundle.js:1:21590
  at qi (/storybook/8237.baeda6e6.iframe.bundle.js:532:446894))
  at Yi (/storybook/8237.baeda6e6.iframe.bundle.js:532:458688))
  at bj (/storybook/8237.baeda6e6.iframe.bundle.js:532:459325))
  at aj (/storybook/8237.baeda6e6.iframe.bundle.js:532:459209))
  at bj (/storybook/8237.baeda6e6.iframe.bundle.js:532:459305))
  at aj (/storybook/8237.baeda6e6.iframe.bundle.js:532:459209))
@LaurentDario LaurentDario added the bug Something isn't working label Nov 30, 2023
@vicky-comeau vicky-comeau added in backlog Pull requests for chore team in process the team works on demand and removed in process the team works on demand labels Dec 1, 2023
@vicky-comeau
Copy link
Collaborator

I have just merged a fix for this as a patch.

@vicky-comeau vicky-comeau linked a pull request Dec 1, 2023 that will close this issue
Fix: [IGL-98] Removed error when all scores are null in AreaChart #581
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working in backlog Pull requests for chore team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: [IGL-98] Removed error when all scores are null in AreaChart gsoft-inc/ov-igloo-ui
2 participants
@LaurentDario @vicky-comeau