🚸 Prevent redundant image upload api call #406
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Walkthrough워크스루이 변경사항은 이미지 업로드 및 공지 제출 프로세스와 관련된 두 파일의 수정 사항을 포함합니다. 변경 사항
시퀀스 다이어그램sequenceDiagram
participant User
participant UploadComponent
participant ImageAPI
participant NoticeSubmission
User->>UploadComponent: 이미지 선택
alt 이미지 있음
UploadComponent->>ImageAPI: 이미지 업로드 요청
ImageAPI-->>UploadComponent: 이미지 키 배열 반환
UploadComponent->>NoticeSubmission: 이미지 키와 함께 공지 제출
else 이미지 없음
UploadComponent->>NoticeSubmission: 빈 이미지 키 배열로 공지 제출
end
시 (토끼의 노래)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/app/[lng]/write/handle-notice-submit.ts (1)
185-186: 불필요한 API 호출 방지 로직이 잘 구현되었습니다!이미지가 있을 때만
uploadImages를 호출하고, 없을 경우 빈 배열을 반환하도록 최적화가 잘 되었습니다. 이는 불필요한 네트워크 요청을 줄이는 좋은 개선사항입니다.다만, 한 가지 제안드리고 싶은 점이 있습니다:
- const imageKeys = - images.length > 0 ? await uploadImages(images).catch(() => null) : []; + const imageKeys = images.length === 0 + ? [] + : await uploadImages(images).catch(() => null);위와 같이 조건문을 재구성하면 로직의 의도가 더 명확해질 것 같습니다. 이미지가 없는 경우를 먼저 처리함으로써 주요 로직의 가독성이 개선될 수 있습니다.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/api/image/image.ts(1 hunks)src/app/[lng]/write/handle-notice-submit.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: preview-deploy
🔇 Additional comments (1)
src/api/image/image.ts (1)
6-6: API 응답 타입 명시 추가가 잘 되었습니다!
post메서드에<string[]>타입 파라미터를 추가하여 타입 안정성이 향상되었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
업로드 이미지가 없을 경우 api를 호출하지 않는 간단한 로직변경을 하였습니다.
Summary by CodeRabbit
새로운 기능
버그 수정