🚀 Change staging deploy method from ECR to github registry #393
Conversation
📝 Walkthrough📝 WalkthroughWalkthrough이 PR은 Changes
Possibly related issues
Poem
Warning Rate limit exceeded@dohyun-ko has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 1 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
.github/workflows/staging.yaml (2)
Line range hint
55-87: ECR 관련 단계들을 제거해야 합니다.GitHub Container Registry로 마이그레이션하는 과정에서 기존 ECR 관련 설정이 그대로 남아있습니다. 이는 불필요한 중복 작업을 유발할 수 있습니다.
다음 단계들을 제거해 주세요:
- AWS 자격 증명 설정
- ECR 로그인
- ECR로의 이미지 빌드 및 푸시
- - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v4 - with: - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ap-northeast-2 - - - name: Login to Amazon ECR - id: login-ecr - uses: aws-actions/amazon-ecr-login@v2 - - - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v3 - - - name: Build, tag, and push image to Amazon ECR - uses: docker/build-push-action@v5 - env: - ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }} - ECR_REPOSITORY: ziggle-frontend - IMAGE_TAG: dev${{ github.run_number }} - with: - context: . - push: true - tags: ${{ env.ECR_REGISTRY }}/${{ env.ECR_REPOSITORY }}:${{ env.IMAGE_TAG }} - cache-from: type=gha - cache-to: type=gha,mode=max🧰 Tools
🪛 yamllint
[error] 43-43: trailing spaces
(trailing-spaces)
43-43: 후행 공백을 제거해 주세요.43번 라인에 불필요한 공백이 있습니다.
🧰 Tools
🪛 yamllint
[error] 43-43: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/staging.yaml(3 hunks)
🧰 Additional context used
🪛 yamllint
.github/workflows/staging.yaml
[error] 43-43: trailing spaces
(trailing-spaces)
🔇 Additional comments (2)
.github/workflows/staging.yaml (2)
8-11: 환경 변수 설정이 적절합니다.
GitHub Container Registry를 위한 환경 변수들이 잘 정의되어 있습니다.
27-54: GitHub Container Registry 관련 설정이 올바르게 구성되었습니다.
Docker 이미지 빌드 및 푸시 과정이 GitHub Container Registry에 맞게 잘 구성되어 있습니다. 캐시 설정도 적절히 되어있어 빌드 성능도 최적화되어 있습니다.
🧰 Tools
🪛 yamllint
[error] 43-43: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/staging.yaml (1)
Line range hint
55-89: 불필요한 중복 코드와 사용하지 않는 ECR 관련 단계를 제거해주세요.다음과 같은 문제점들이 발견되었습니다:
- Docker Buildx 설정이 중복되어 있습니다 (43행과 71행)
- ECR 관련 단계들이 더 이상 사용되지 않습니다 (56-85행)
다음과 같이 수정하는 것을 제안드립니다:
- name: Build and push Docker image id: push uses: docker/build-push-action@v6 with: context: . push: true tags: ${{ steps.meta.outputs.tags }} labels: ${{ steps.meta.outputs.labels }} cache-from: type=gha cache-to: type=gha,mode=max - - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v4 - with: - aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - aws-region: ap-northeast-2 - - - name: Login to Amazon ECR - id: login-ecr - uses: aws-actions/amazon-ecr-login@v2 - - - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v3 - - - name: setup environment - run: | - echo "${{ vars.ENV }}" >> .env.production - echo "NEXTAUTH_SECRET=${{ secrets.NEXTAUTH_SECRET }}" >> .env.production - echo "IDP_CLIENT_SECRET=${{ secrets.IDP_CLIENT_SECRET }}" >> .env.production - - - name: Build, tag, and push image to Amazon ECR - uses: docker/build-push-action@v5 - env: - ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }} - ECR_REPOSITORY: ziggle-frontend - IMAGE_TAG: dev${{ github.run_number }} - with: - context: . - push: true - tags: ${{ env.REGISTRY }}/${{ env.REPOSITORY }}:${{ env.IMAGE_TAG }} - cache-from: type=gha - cache-to: type=gha,mode=max
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/staging.yaml(3 hunks)
🧰 Additional context used
🪛 yamllint
.github/workflows/staging.yaml
[error] 44-44: trailing spaces
(trailing-spaces)
🔇 Additional comments (3)
.github/workflows/staging.yaml (3)
7-12: 수동 실행 트리거와 환경 변수 설정이 적절합니다!
워크플로우 디스패치 트리거 추가와 GitHub Container Registry를 위한 환경 변수 설정이 잘 되어있습니다.
28-54: GitHub Container Registry 설정이 올바르게 구성되었습니다!
컨테이너 레지스트리 로그인, 메타데이터 추출, 그리고 빌드/푸시 단계가 잘 구성되어 있습니다.
🧰 Tools
🪛 yamllint
[error] 44-44: trailing spaces
(trailing-spaces)
104-104: 매니페스트 파일 존재 여부를 확인해주세요.
infoteam/service/ziggle/next.stg.yaml 파일이 올바른 위치에 있는지 확인이 필요합니다.
다음 스크립트를 실행하여 매니페스트 파일의 존재 여부를 확인합니다:
Summary by CodeRabbit