core: Added changes to DelayedStream.setStream() should cancel the provided stream if not using it #11969
+154
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovided stream if not using it
vinodhabib
reviewed
Mar 19, 2025
| @@ -271,14 +272,41 @@ public void uncaughtException(Thread t, Throwable e) { | |||
| verifyNoMoreInteractions(mockRealStream); | |||
| } | |||
|
|
|||
| @Test | |||
| public void newStreamThenShutDownNow() { | |||
There was a problem hiding this comment.
append test with UT method name -> testNewStreamThenShutDownNow()
vinodhabib
reviewed
Mar 19, 2025
| ClientStream stream = delayedTransport.newStream( | ||
| method, new Metadata(), CallOptions.DEFAULT, tracers); | ||
| stream.start(streamListener); | ||
| assertEquals(1,delayedTransport.getPendingStreamsCount()); |
There was a problem hiding this comment.
add an empty line above asserts statements in all applicable places.
vinodhabib
reviewed
Mar 19, 2025
…ovided stream if not using it
vinodhabib
reviewed
Mar 21, 2025
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
remove an empty line here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core: Added changes to DelayedStream.setStream() should cancel the provided stream if not using it
Fixes: #1537