Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added python 3.11 compatibility #342

Closed
wants to merge 1 commit into from

Conversation

sanjif-shanmugavelu
Copy link
Collaborator

Added python 3.11 compatibility in /src/onnxflow/build.py as per Gleb's request

Copy link
Collaborator

@ataheridezfouli-groq ataheridezfouli-groq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just want to make sure, at least one test has been run that tests this code? Also is mlagility still compatible with python 3.8 ? Or should we update that as well?

@sanjif-shanmugavelu
Copy link
Collaborator Author

sanjif-shanmugavelu commented Aug 19, 2024

Hey Arash, I ran the scripts at /mlagility/examples/cli/scripts to test. I should probably should do more thorough testing though...

Not sure about python 3.8, I suspect the cpu/gpu tests will run fine, not sure about the groq tests though. Will look into this and update if necessary. Thanks!

@ataheridezfouli-groq
Copy link
Collaborator

ataheridezfouli-groq commented Aug 19, 2024

Hey Arash, I ran the scripts at /mlagility/examples/cli/scripts to test. I should probably should do more thorough testing though...

Not sure about python 3.8, I suspect the cpu/gpu tests will run fine, not sure about the groq tests though. Will look into this and update if necessary. Thanks!

That sounds good, as long as it exercises that piece of code. And yeah doesn't matter whether it's CPU/GPU or Groq for this MR.

Copy link

github-actions bot commented Nov 1, 2024

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 1, 2024
Copy link

github-actions bot commented Nov 9, 2024

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants