RavenDB-23704 - use a const

grisha-kotler · Mar 5, 2025 · 9a72254 · 9a72254
1 parent 3a6b940
commit 9a72254
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Sparrow.Server/ByteString.cs b/src/Sparrow.Server/ByteString.cs
@@ -671,6 +671,7 @@ public sealed class ByteStringContext : ByteStringContext<ByteStringMemoryCache>
         public const int MaxAllocationBlockSizeInBytes = 256 * MinBlockSizeInBytes;
         public const int DefaultAllocationBlockSizeInBytes = 1 * MinBlockSizeInBytes;
         public const int MinReusableBlockSizeInBytes = 8;
+        public const int MaxAllocatedBlockSize = 2 * Sparrow.Global.Constants.Size.Megabyte;
 
         static unsafe ByteStringContext()
         {
@@ -1040,7 +1041,7 @@ private ByteString AllocateExternal(byte* valuePtr, int size, ByteStringType typ
             {
                 if (_externalCurrentLeft == 0)
                 {
-                    var tmp = Math.Min(2 * Sparrow.Global.Constants.Size.Megabyte, AllocationBlockSize * 2);
+                    var tmp = Math.Min(ByteStringContext.MaxAllocatedBlockSize, AllocationBlockSize * 2);
                     AllocateExternalSegment(tmp);
                     AllocationBlockSize = tmp;
                 }
@@ -1184,7 +1185,7 @@ private ByteString AllocateInternalUnlikely(int length, int allocationUnit, Byte
             }
             else
             {
-                AllocationBlockSize = Math.Min(2 * Sparrow.Global.Constants.Size.Megabyte, AllocationBlockSize * 2);
+                AllocationBlockSize = Math.Min(ByteStringContext.MaxAllocatedBlockSize, AllocationBlockSize * 2);
                 var toAllocate = Math.Max(AllocationBlockSize, allocationUnit);
                 _internalCurrent = AllocateSegment(toAllocate);
                 Debug.Assert(_internalCurrent.SizeLeft >= allocationUnit, $"{_internalCurrent.SizeLeft} >= {allocationUnit}");

diff --git a/test/FastTests/Sparrow/ByteStringTests.cs b/test/FastTests/Sparrow/ByteStringTests.cs
@@ -1,5 +1,4 @@
-using Sparrow.Global;
-using Sparrow.Server;
+using Sparrow.Server;
 using Sparrow.Threading;
 using Tests.Infrastructure;
 using Xunit;
@@ -200,12 +199,12 @@ public void CanReuseMemory()
         {
             using (var context = new ByteStringContext<ByteStringDirectAllocator>(SharedMultipleUseFlag.None))
             {
-                while (context.AllocationBlockSize != 2 * Constants.Size.Megabyte)
+                while (context.AllocationBlockSize != ByteStringContext.MaxAllocatedBlockSize)
                 {
                     context.Allocate(ByteStringContext.MinBlockSizeInBytes / 2, out _);
                 }
 
-                Assert.Equal(2 * Constants.Size.Megabyte, context.AllocationBlockSize);
+                Assert.Equal(ByteStringContext.MaxAllocatedBlockSize, context.AllocationBlockSize);
 
                 const int toAllocate = ByteStringContext.MinBlockSizeInBytes * 5;
                 context.Allocate(toAllocate, out var first);