Fix: Convert scanner style bools to OSP style

[mattmundell]

What:

Convert scanner style yes/no boolean preferences to OSP style 1/0 before sending the preferences to ospd.

Why:

I had to do this to get scans to run (using the openvasd-integration branch of gvmd). Maybe helps someone else.

How:

With Rust openvas-scanner main branch, I start a Full and Fast task in GSA. The task sits in Requested and I see Invalid safe_checks value in the openvasd logs:

2025-01-13T22:56:25.950648Z WARN openvasd::scheduling: unable to start, removing from queue and set status to failed. Verify that scan using the API scan_id=1a0299e6-8b6f-428f-9405-7baa393511b4 e=Unexpected issue: InvalidResponse(Status { text: "Invalid safe_checks value", code: StringU64(400) })

openvasd.toml includes:

mode = "service"
[scanner]
type = "ospd"
[storage]
type = "inmemory"

With the PR the scan starts and runs to completion.

References:

Similar conversion is done in launch_osp_openvas_task in manage.c#L2815 in gvmd.

Checklist:

• Tests
• PR merge commit message adjusted

[nichtsfrei]

In rust you don't need to create a variable before assigning it. It is considered a bad practice.

A better way to handle it would be:

        let value = match p.value.as_ref() {
            "yes" => "1",
            "no" => "0",
            v => v,
        };
        writer.write_event(Event::Text(BytesText::new(value)))?;

This way value does not need to be mutable which makes it a bit easier for the borrow checker when compiling it and for the reader as both don't have to lookout for potential side effects.

[mattmundell]

Thanks Philipp, I thought it would need improvement. Changed in ed8f23e.