Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SequentialWorkQueue easier to use in complex asynchronous code execution scenarios #8

Merged
merged 2 commits into from
May 8, 2024
Merged

Make SequentialWorkQueue easier to use in complex asynchronous code execution scenarios #8

merged 2 commits into from
May 8, 2024

Conversation

Moncader
Copy link
Contributor

  • feat: allow to choose whether to wait for microtasks, timers, and periodic timers in a SequentialWorkQueue, as well as ProviderModel's lock function.
  • feat: remove the limitation of not being able to add to a SequentialWorkQueue inside the work callback of a SequentialWorkQueue.
  • fix: make sure SequentialWorkQueue's processes can't cancel themselves.

Issue Number

fixes #7

Summary

  • This PR makes using the SequentialWorkQueue system a bit easier in complex situation dealing with Futures, microtasks, timers, etc.
  • This PR lets you choose if you would like to wait for the completion of the above mentioned dart features before letting the next work in the queue run.

@Moncader
feat: allow to choose whether to wait for microtasks, timers, and per…
a8186db 
…iodic timers in a SequentialWorkQueue, as well as ProviderModel's lock function.

feat: remove the limitation of not being able to add to a SequentialWorkQueue inside the work callback of a SequentialWorkQueue.
fix: make sure SequentialWorkQueue's processes can't cancel themselves.
@Moncader Moncader merged commit 8f38a6e into gree:main May 8, 2024
2 checks passed
@Moncader Moncader deleted the feature/better-sequential-queue branch May 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsuyani556 matsuyani556 matsuyani556 approved these changes

@toshiaki-satsuma toshiaki-satsuma toshiaki-satsuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make SequentialWorkQueue easier to use and more predictable with futures, timers, etc...
3 participants
@Moncader @matsuyani556 @toshiaki-satsuma