gpcp-show-original-price.js: Fixed an issue with snippet not working.

[saifsultanc]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2908466617/82201?

Summary

Dependent on https://github.com/gravitywiz/gwconditionalpricing/pull/74

Fixing snippet not working!

[coderabbitai]

Walkthrough

The changes update the event handler for the 'gpcp_after_update_pricing' action in the JavaScript file responsible for showing the original price in a conditional pricing scenario. The handler's parameter list has been reordered and expanded to include triggerFieldId as the first argument, followed by GWConditionalPricing and productId. Additionally, the jQuery selector used to locate the relevant price display element now uses a #field_ prefix instead of #input_, altering how the DOM element is targeted. The core logic for displaying or removing the original price remains unchanged.

Changes

File(s)	Change Summary
gp-conditional-pricing/gpcp-show-original-price.js	Modified event handler signature for 'gpcp_after_update_pricing' and updated jQuery selector prefix.

Suggested reviewers

• veryspry

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ae5515 and 578420d.

📒 Files selected for processing (1)

• gp-conditional-pricing/gpcp-show-original-price.js (1 hunks)

🔇 Additional comments (2)

gp-conditional-pricing/gpcp-show-original-price.js (2)

17-17:

✅ Verification successful

Selector updated from #input_ to #field_ to target the correct element.

This change fixes the issue where the snippet wasn't working by targeting the correct DOM element. The selector now uses #field_{formId}_{productId} instead of #input_{formId}_{productId}, which properly identifies the element containing the price display.

---

🏁 Script executed:

#!/bin/bash
# Let's check if there are consistent patterns for field selectors in the codebase

echo "Searching for both input_ and field_ selectors in JS files..."
rg "(#input_|#field_)" --type js

Length of output: 9359

---

Confirmed correct selector change to field wrapper

• In gp-conditional-pricing/gpcp-show-original-price.js (line 17), the selector has been updated to

  $( '#field_{0}_{1}'.gformFormat( GWConditionalPricing._formId, productId ) );

  This now correctly targets the field container where the original price is displayed, replacing the previous #input_{formId}_{productId} selector. No further changes needed.

---

10-10:

✅ Verification successful

Function signature updated to align with the GPCP event handler.

The event handler for 'gpcp_after_update_pricing' has been modified to match changes in the associated event parameters. The function now properly receives triggerFieldId as the first parameter, with productId moved to the third position.

---

🏁 Script executed:

#!/bin/bash
# Let's check if this event action is used elsewhere in the codebase with a different signature

echo "Searching for other instances of gpcp_after_update_pricing..."
rg "gpcp_after_update_pricing" --type js

Length of output: 455

---

🏁 Script executed:

#!/bin/bash
# Inspect update_price_labels definition and its usage with gpcp_after_update_pricing
echo "Function definition for update_price_labels:"
rg -n "function update_price_labels" -n gp-conditional-pricing/gpcp-product-pricing-labels.js -A 3

echo
echo "gform.addAction call for gpcp_after_update_pricing in gpcp-product-pricing-labels.js:"
rg -n "gform.addAction.*gpcp_after_update_pricing" -n gp-conditional-pricing/gpcp-product-pricing-labels.js -A 2

Length of output: 911

---

All gpcp_after_update_pricing callbacks verified
The inline handler in gp-conditional-pricing/gpcp-show-original-price.js now correctly accepts (triggerFieldId, GWConditionalPricing, productId). The only other registration in gp-conditional-pricing/gpcp-product-pricing-labels.js uses an argument-less callback (update_price_labels), which doesn’t rely on any event parameters. No further changes needed.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

	Warnings
⚠️	When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 578420d