Adds AWS Role ARN to IC Integration settings #53024
Open
+1,705
−653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Identity Center integration needs to be able to assume an AWS role when using the ambient system credentials. This patch updates the IC integration protobuf definition to include the role ARN, by refactoring the settings block to replace the CredentialSource enumeration with a `Credentials` type containing a `oneof` union of System and OIDC credential blocks. The CredentalSource value is preserved for backwards compatibility with previous Teleport releases. This patch includes - the updated protobuf message and generated types - update tests, etc - updated `tctl` to handle new plugin settings structure Chagnges required to actually use this information are coming in a later PR.
tcsc
added
no-changelog
Tener
approved these changes
Mar 13, 2025
zmb3
approved these changes
Mar 13, 2025
|
|
||
| if c.CredentialsSource == AWSICCredentialsSource_AWSIC_CREDENTIALS_SOURCE_OIDC && c.IntegrationName == "" { | ||
| return trace.BadParameter("AWS OIDC integration name must be set") | ||
| // Handle legacy records that pre-date the polymorphic Credentials settings |
There was a problem hiding this comment.
Suggested change
| // Handle legacy records that pre-date the polymorphic Credentials settings | |
| // Handle legacy records that pre-date the polymorphic Credentials settings | |
| // TODO(tcsc): remove this check in v19 |
public-teleport-github-review-bot
bot
removed request for
espadolini and
smallinsky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Identity Center integration needs to be able to assume an AWS role
when using the ambient system credentials. This patch updates the IC
integration protobuf definition to include the role ARN, by refactoring
the settings block to replace the CredentialSource enumeration with a
Credentialstype containing aoneofunion of System and OIDC credential blocks.The CredentalSource value is preserved for backwards compatibility with previous
Teleport releases.
This patch includes
tctlto handle new plugin settings structureChagnges required to actually use this information are coming in a later PR.