[v17] lib/utils/typical: support == and != operators for integers
#52991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #52460, we're adopting the Teleport predicate language for Workload Identity rules. We currently allow you to match on the equality/inequality of the attested process' PID, GID, and UID, but this wasn't supported in the predicate language. We now check the operand types at compile-time and choose the correct booleanOperator. If both operands are dynamically typed (e.g. `ifelse`) we do not allow you to use the `==` or `!=` operators.
zmb3
approved these changes
Mar 12, 2025
rosstimothy
approved these changes
Mar 12, 2025
public-teleport-github-review-bot
bot
removed request for
strideynet,
nklaassen and
EdwardDowling
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #52521 to branch/v17
changelog: You can now use
==and!=operators with integer operands in Teleport predicate language