-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new release #340
Comments
We have some breaking changes merged into master but I think they are so small that they don't really merit a version bump yet. We should probably cherry-pick the non-breaking stuff into a |
Well, actually, #312 is really minor and |
I landed changes to release automation. I think we want #353 and then we can do a release. We should do a minor (not patch) version bump as we increased the minimum rust version. |
If we are doing a minor now we should also include #333 since it provide a significant usability improvement. The That does bump rust requirement to 1.34, but only if you use certain attributes on field resolvers with the new That way we won't need another minor bump until |
Hmmm, that is a huge change. I'd prefer to do a release with current state and then land that, have it sit in master for a bit, and then cut another one. |
It's a big change but not a user visible one right away since everyone will still be on the old macro. Also I've converted one large and two smallish projects and all works fine. It wouldn't see much testing on master anyway. |
I don't think we need to wait on the book here. Do you want to run a release or shall I? |
Can do, but since you did all the work on the releasing tool, you should have the honors of breaking it in. |
Ok, I'll do a release later tonight! Probably best for me to do it so if automation breaks I can fix it |
@LegNeato please also check Gitter, I sent you a message with a nice surprise. |
Juniper 0.12.0 is out! Automation seemed to work well. |
@LegNeato for future reference, what was brittle about it? |
The cargo-release parts error out when pushing to git if your repo's git remote branch isn't in sync with upstream/master. A clean clone with this repo as origin makes all those issues impossible, so that's what I added to the docs. |
It's about time to push out a new release. I want to automate a bit more of the process as well.
We probably need the book updating working too.
The text was updated successfully, but these errors were encountered: