From e6d5b873e2824c3c26f8c7214c2c39267c072593 Mon Sep 17 00:00:00 2001 From: Rahul Patel Date: Wed, 12 Jun 2024 12:34:41 +0530 Subject: [PATCH 1/2] Update annotation for client.execute_batch, get_execution_result argument. client.execute_batch was showing "No overload for provided arguments" in Pylance for vscode. Had to provide argument for get_execution_result to suppress error. Update overloads to have default values to overcome this. --- gql/client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gql/client.py b/gql/client.py index 0d9e36c7..83afb357 100644 --- a/gql/client.py +++ b/gql/client.py @@ -498,7 +498,7 @@ def execute_batch( *, serialize_variables: Optional[bool] = None, parse_result: Optional[bool] = None, - get_execution_result: Literal[False], + get_execution_result: Literal[False] = False, **kwargs, ) -> List[Dict[str, Any]]: ... # pragma: no cover @@ -510,7 +510,7 @@ def execute_batch( *, serialize_variables: Optional[bool] = None, parse_result: Optional[bool] = None, - get_execution_result: Literal[True], + get_execution_result: Literal[True] = True, **kwargs, ) -> List[ExecutionResult]: ... # pragma: no cover From 49438d6aa3608dfcd20b5b34e3b9423fd863034a Mon Sep 17 00:00:00 2001 From: Leszek Hanusz Date: Sun, 28 Jul 2024 17:48:01 +0200 Subject: [PATCH 2/2] Fix annotation for get_execution_result to be similar in all methods --- gql/client.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gql/client.py b/gql/client.py index 83afb357..e8ef3c64 100644 --- a/gql/client.py +++ b/gql/client.py @@ -262,7 +262,7 @@ def execute_batch_sync( *, serialize_variables: Optional[bool] = None, parse_result: Optional[bool] = None, - get_execution_result: Literal[False], + get_execution_result: Literal[False] = ..., **kwargs, ) -> List[Dict[str, Any]]: ... # pragma: no cover @@ -498,7 +498,7 @@ def execute_batch( *, serialize_variables: Optional[bool] = None, parse_result: Optional[bool] = None, - get_execution_result: Literal[False] = False, + get_execution_result: Literal[False] = ..., **kwargs, ) -> List[Dict[str, Any]]: ... # pragma: no cover @@ -510,7 +510,7 @@ def execute_batch( *, serialize_variables: Optional[bool] = None, parse_result: Optional[bool] = None, - get_execution_result: Literal[True] = True, + get_execution_result: Literal[True], **kwargs, ) -> List[ExecutionResult]: ... # pragma: no cover @@ -1103,7 +1103,7 @@ def execute_batch( *, serialize_variables: Optional[bool] = None, parse_result: Optional[bool] = None, - get_execution_result: Literal[False], + get_execution_result: Literal[False] = ..., **kwargs, ) -> List[Dict[str, Any]]: ... # pragma: no cover