Always add hours to SRT encoding

It [appears][1] that the SRT format always requires hours. 1: https://en.wikipedia.org/wiki/SubRip#SubRip_file_format
grain-team · Jul 20, 2023 · a3e8222 · a3e8222
1 parent 40e9cde
commit a3e8222
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/vttyl/encode.ex b/lib/vttyl/encode.ex
@@ -24,7 +24,7 @@ defmodule Vttyl.Encode do
 
     # Lop off hours if there aren't any
     hr_and_min =
-      if hours <= 0 do
+      if hours <= 0 and type == :vtt do
         prefix_fmt(minutes)
       else
         [hours, minutes]

diff --git a/test/vttyl_test.exs b/test/vttyl_test.exs
@@ -137,7 +137,7 @@ defmodule VttylTest do
     end
 
     test "basic", %{parts: parts} do
-      assert make_srt(1, "00:01,000", "00:10,000", "Hello world") == Vttyl.encode_srt(parts)
+      assert make_srt(1, "00:00:01,000", "00:00:10,000", "Hello world") == Vttyl.encode_srt(parts)
     end
 
     test "multi line" do
@@ -157,8 +157,8 @@ defmodule VttylTest do
       ]
 
       expect =
-        make_srt(1, "00:01,000", "00:10,000", "Hello") <>
-          "\n" <> make_srt(2, "00:02,000", "00:20,000", "world")
+        make_srt(1, "00:00:01,000", "00:00:10,000", "Hello") <>
+          "\n" <> make_srt(2, "00:00:02,000", "00:00:20,000", "world")
 
       assert expect == Vttyl.encode_srt(parts)
     end