feat(stdlib): Add Array.slice function #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
reviewed
Jun 11, 2021
peblair
requested changes
Jun 13, 2021
phated
force-pushed
the
stdlib/array-slice
branch
from
3c86962 to
9eb8922
Compare
phated
force-pushed
the
stdlib/array-slice
branch
from
1298bb7 to
261f688
Compare
Co-authored-by: Oscar Spencer <oscar@grain-lang.org>
Co-authored-by: Oscar Spencer <oscar@grain-lang.org>
|
Rebased, and I believe I got all of the comments I lost in the force push experiment. |
ospencer
approved these changes
Jun 14, 2021
Co-authored-by: Oscar Spencer <oscar@grain-lang.org>
peblair
approved these changes
Jun 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #711 - I've begun splitting out the changes from the "misc" section of #680
This adds
sliceto the Array stdlib. I actually rewrote the function because I believe our guiding principals on the stdlib is to be graceful where possible. This change is likely to be a bit controversial for the team so I'd like feedback if anyone doesn't think we should handle indexes too large or negative indexing from the end.