feat(stdlib): Add List.join and Array.join functions #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
approved these changes
Jun 11, 2021
|
peblair
force-pushed
the
stdlib/list-join
branch
from
e55ede0 to
6866133
Compare
peblair
approved these changes
Jun 13, 2021
peblair
force-pushed
the
stdlib/list-join
branch
from
6866133 to
c3ece29
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #711 - I've begun splitting out the changes from the "misc" section of #680
This originally was
String.join, but I changed it toList.joinsince it is actually joining a List into a String. I addedArray.jointoo. And then I regenerated the snapshots because they are crazy.