-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): Optimize ==
for lists
#2247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
reviewed
Feb 17, 2025
ospencer
reviewed
Feb 17, 2025
ospencer
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test with a very very long list?
This was referenced Feb 17, 2025
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
874d4de
to
44e2f73
Compare
I added that test and this should be ready to merge now. |
ospencer
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes
==
for specifically for lists and also refactors it to use early return. Instead of the recursive approach used in the general case for adt's because we know lists will always have two elements (item, nextItemPtr) we handle it in an iterative manner avoiding the stack overflow.Notes:
==
is bundled to every grain program.==
would now lock with a cyclic list, however from my understanding such a list would be impossible to build in grain.List.init
around5005
elements.Closes: #2246