Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isNaN and isFinite utility functions for Number #704

Closed
cician opened this issue Jun 6, 2021 · 2 comments
Closed

isNaN and isFinite utility functions for Number #704

cician opened this issue Jun 6, 2021 · 2 comments
Labels
enhancement stdlib

Comments

@cician
Copy link
Contributor

cician commented Jun 6, 2021

As a user I need to detect NaNs ind +/-infinite Numbers.

I think it needs to be done with functions similar to numberUtils.isNaN and isFinite already present in the runtime. These functions are only for WASM primitives and not exposed.

Should this be part of the Number module currently in the making (#687)?
@peblair
Copy link
Member

peblair commented Jun 6, 2021

Should this be part of the Number module currently in the making (#687)?

It can go inside of that module, but I think it should be a separate pull request.

@cician
Copy link
Contributor Author

cician commented Jun 15, 2021

Implemented with PR #729 and merged to main.

@cician cician closed this as completed Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement stdlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cician @peblair