Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove graalvm dependencies only required by asset-pipeline gradle plugin #13992

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

codeconsole
Copy link
Contributor

@codeconsole codeconsole commented Feb 1, 2025

These should only be resolved during build process or bootRun by the asset pipeline gradle plugin.

Setting the version of graalvm outside of the asset pipeline plugin results in missing dependencies and unexpected behavior.

Allows:
bertramdev/asset-pipeline#370

@codeconsole
Copy link
Contributor Author

#13983

@codeconsole
Copy link
Contributor Author

#13990

Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the gradle.properties file also be regenerated with ./gradlew grails-bom:syncProps as part of this PR?

@codeconsole
Copy link
Contributor Author

codeconsole commented Feb 3, 2025

Should the gradle.properties file also be regenerated with ./gradlew grails-bom:syncProps as part of this PR?

@matrei yes, maybe I should make syncProps work automatically if changes are detected

@codeconsole
Copy link
Contributor Author

@matrei can you take a look at bertramdev/asset-pipeline#370

@codeconsole codeconsole merged commit 322b0ee into grails:7.0.x Feb 3, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants