Extract a Grails Common package that can be shared between GORM & Grails

[jdaugherty]

Feature description

There are several utility classes from the Grails 7 migration that have been duplicated between GORM & Grails Core. Since GORM is not meant to depend on Grails Core, we should introduce a common library dependency to avoid code duplication.

Initially, this would include:

1. A common interface for @Validateable & @GormValidateable
2. The various org.grails.asm.* classes that were copied from Spring to support annotation reading.

[jeffscottbrown]

Since GORM is not meant to depend on Grails Core, we should introduce a common library dependency to avoid code duplication.

grails-datastore-gorm-support currently has api dependencies on grails-core and grails-bootstrap (grails-datastore-gorm-support/build.gradle), and compile time dependencies on grails-web-common and grails-web-url-mappings (grails-datastore-gorm-support/build.gradle).

Do you anticipate that all of those dependencies would be removed?

[jdaugherty]

Since GORM is not meant to depend on Grails Core, we should introduce a common library dependency to avoid code duplication.

grails-datastore-gorm-support currently has api dependencies on grails-core and grails-bootstrap (grails-datastore-gorm-support/build.gradle), and compile time dependencies on grails-web-common and grails-web-url-mappings (grails-datastore-gorm-support/build.gradle).

Do you anticipate that all of those dependencies would be removed?

It looks like before they were dependencies with explicit exclusions so they could be used in other projects. I assume we should add those exclusions back, but have not dug into it too deeply.

[matrei]

Two classes that have been "temporarily" copied to grails-views-gradle-plugin to decouple grails-views and are candidates for moving to grails-common are:

• https://github.com/grails/grails-core/blob/7.0.x/grails-bootstrap/src/main/groovy/grails/util/GrailsNameUtils.java
• https://github.com/grails/grails-gradle-plugin/blob/7.0.x/src/main/groovy/org/grails/gradle/plugin/util/SourceSets.groovy

[jdaugherty]

As part of this ticket, we discovered the grails-datstore-gorm tests weren't running. They are fixed in 9.x, but did not run in 8.x. It also looks like the classpath has changed in gorm since the test MethodValidationTransformerSpec was written. This class fails because it's looking for the gorm version of ValidateException instead of the grails-core version. For now the test has been updated to use the grails-core version, but as part of introducing common, we just need to just have a common exception base.